Add git-client exclude #4232
Merged
Add git-client exclude #4232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
MarkEWaite
approved these changes
Jan 17, 2025
6 tasks
MarkEWaite
added a commit
to MarkEWaite/bom
that referenced
this pull request
Jan 18, 2025
The git client 5.0.0 automated tests unintentionally tested a command line git behavior that changed in command line git 2.48.0. The test is fixed in git client plugin 5.0.2 and git client plugin 6.1.1. More details are available in: * jenkinsci/git-client-plugin#1242 Resolves the test failure in the plugin BOM that required the addition of a test exclusion in: * jenkinsci#4232 * jenkinsci#4233 Testing done: * Confirmed that the test fails before this change with: PLUGINS=git-client LINE=2.462.x TEST=GitAPITest bash ./local-test.sh * Confirmed that the test passes after this change with: PLUGINS=git-client LINE=2.462.x TEST=GitAPITest bash ./local-test.sh
6 tasks
darinpope
pushed a commit
that referenced
this pull request
Jan 18, 2025
The git client 5.0.0 automated tests unintentionally tested a command line git behavior that changed in command line git 2.48.0. The test is fixed in git client plugin 5.0.2 and git client plugin 6.1.1. More details are available in: * jenkinsci/git-client-plugin#1242 Resolves the test failure in the plugin BOM that required the addition of a test exclusion in: * #4232 * #4233 Testing done: * Confirmed that the test fails before this change with: PLUGINS=git-client LINE=2.462.x TEST=GitAPITest bash ./local-test.sh * Confirmed that the test passes after this change with: PLUGINS=git-client LINE=2.462.x TEST=GitAPITest bash ./local-test.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the fixes in #4200, this breaks the bom build for 2.452.x and 2.462.x.
Need to ignore the test until both 2.452.x and 2.462.x go away.
Testing done
none
Submitter checklist