Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use git client 5.0.2 in the 2.452.x and 2.462.x lines #4240

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Jan 18, 2025

Use git client 5.0.2 in the 2.452.x and 2.462.x lines

The git client 5.0.0 automated tests unintentionally tested a command line git behavior that changed in command line git 2.48.0. The test is fixed in git client plugin 5.0.2 and git client plugin 6.1.1.

More details are available in:

Resolves the test failure in the plugin BOM that required the addition of a test exclusion in:

Testing done

  • Confirmed that the test fails before this change with:

    PLUGINS=git-client LINE=2.462.x TEST=GitAPITest bash ./local-test.sh

  • Confirmed that the test passes after this change with:

    PLUGINS=git-client LINE=2.462.x TEST=GitAPITest bash ./local-test.sh

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

The git client 5.0.0 automated tests unintentionally tested a command
line git behavior that changed in command line git 2.48.0.  The test is
fixed in git client plugin 5.0.2 and git client plugin 6.1.1.

More details are available in:

* jenkinsci/git-client-plugin#1242

Resolves the test failure in the plugin BOM that required the addition of a test exclusion in:

* jenkinsci#4232
* jenkinsci#4233

Testing done:

* Confirmed that the test fails before this change with:

  PLUGINS=git-client LINE=2.462.x TEST=GitAPITest bash ./local-test.sh

* Confirmed that the test passes after this change with:

  PLUGINS=git-client LINE=2.462.x TEST=GitAPITest bash ./local-test.sh
@MarkEWaite MarkEWaite requested a review from a team as a code owner January 18, 2025 11:57
@MarkEWaite MarkEWaite added the bug Something isn't working label Jan 18, 2025
Copy link
Contributor

@darinpope darinpope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified with

  • LINE=weekly PLUGINS=git-client bash local-test.sh
  • LINE=2.479.x PLUGINS=git-client bash local-test.sh
  • LINE=2.462.x PLUGINS=git-client bash local-test.sh
  • LINE=2.452.x PLUGINS=git-client bash local-test.sh

@darinpope darinpope merged commit 5aa8265 into jenkinsci:master Jan 18, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants