Set forkCount to speed up builds #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
commented
Mar 10, 2021
| SNAPSHOT_VERSION=0.5.1-SNAPSHOT # TODO incrementals broken till https://github.com/jenkinsci/plugin-compat-tester/pull/260 is merged | ||
| version=0.5.1-20201017.070523-3 # TODO https://github.com/jenkinsci/plugin-compat-tester/pull/261 | ||
| pct=$HOME/.m2/repository/org/jenkins-ci/tests/plugins-compat-tester-cli/${SNAPSHOT_VERSION}/plugins-compat-tester-cli-${version}.jar | ||
| version=0.5.1-rc1068.959674bdeffd # TODO https://github.com/jenkinsci/plugin-compat-tester/pull/275 |
There was a problem hiding this comment.
…eForks=false will help
…ansferListener=warn is set by jenkinsci/plugin-compat-tester#216
|
@bitwiseman AFAICT jenkinsci/pipeline-model-definition-plugin#415 broke a test added in jenkinsci/pipeline-model-definition-plugin#409, perhaps due to lack of cleanup of mvn -Pquick-build install
mvn -pl pipeline-model-definition -Dtest=ASTParserUtilsTest surefire:testbut this was not caught in CI, perhaps because that plugin does not set |
|
Going to see if reverting #428 works around this for now. |
…g to bother adding that for now
jglick
commented
Mar 11, 2021
| @@ -13,8 +13,7 @@ else | |||
| PCT_S_ARG= | |||
| fi | |||
|
|
|||
| # TODO use -ntp if there is a PCT option to pass Maven options | |||
| MAVEN_PROPERTIES=org.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn:jth.jenkins-war.path=$(pwd)/megawar.war | |||
| MAVEN_PROPERTIES=jth.jenkins-war.path=$(pwd)/megawar.war:forkCount=.75C | |||
There was a problem hiding this comment.
With current ACI agents, this seems to be effectively 3×.
| @@ -114,4 +113,7 @@ rm -fv pct-work/workflow-basic-steps/target/surefire-reports/TEST-org.jenkinsci. | |||
| # TODO until dropping 2.235.x so can rely on https://github.com/jenkinsci/workflow-basic-steps-plugin/pull/120 | |||
| rm -fv pct-work/workflow-basic-steps/target/surefire-reports/TEST-org.jenkinsci.plugins.workflow.steps.TimeoutStepTest.xml | |||
|
|
|||
| # TODO https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/417 | |||
There was a problem hiding this comment.
jglick
changed the title
jglick
requested review from
timja,
oleg-nenashev,
imonteroperez and
bitwiseman
timja
approved these changes
Mar 11, 2021
|
🤞 |
|
https://ci.jenkins.io/job/Tools/job/bom/job/master/buildTimeTrend
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jenkinsci/plugin-compat-tester#273 speeds up builds of bottleneck plugins like
pipeline-model-definitionand makes the overall build completely significantly faster: ~61m → ~42m.