[JENKINS-64846] Fix use of local declared variables inside matrix

[bitwiseman]

• JENKINS issue(s):

  • JENKINS-64846

• Description:

  • We have script splitting turned on by default in most tests. The assumption as was that script splitting being turned on would break things, not make them work unexpectedly. Turns out that is not always the case. With the change to script splitting from 1.8.0, if script splitting is turned off local declared variables do not get retained appropriately in matrix.

• Documentation changes:

  • Link to related jenkins.io PR or explanation for why doc change not needed

• Users/aliases to notify:

  • @abayer

[bitwiseman]

I'm reviewing existing tests to make sure this scenario is covered outside of matrix. It looks like it was not but also is not failing aside from matrix.

[abayer]

Looks reasonable. I do wonder if we might want to make a profile in the POM for turning script splitting on and run the full suite of tests with and without script splitting on in CI?

[bitwiseman]

@abayer
Sounds like a good idea. I plan to make script splitting the default behavior at some point, but until then we should cover both behaviors.

[car-roll]

LGTM, though admittedly I'm just looking more for syntax errors as I'm not completely familiar with the code

[jglick]

I do not get it. Why not just set these flags directly in the code, at runtime, depending on the Java version? Or if you want to test in both modes, use @Parameterized etc. See jenkinsci/bom#451 (comment)