Add icons for search #452
Open
Add icons for search #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
force-pushed
the
restore-icon-spec
branch
from
9acde54 to
3190d98
Compare
timja
commented
Dec 16, 2024
| @Override | ||
| public String getIconClassName() { | ||
| // avoid https://issues.jenkins.io/browse/JENKINS-74990 | ||
| if (icon.getClass().getName().equals("jenkins.branch.MetadataActionFolderIcon")) { |
There was a problem hiding this comment.
not ideal but I couldn't see a cleaner solution.
This if block means that the MetadataActionFolderIcon falls back into the code it previously did before Folder had an IconSpec.
in command palette it works fine because e.g. OrganizationFolder overrides getIconClassName so it gets the right icon, in the example I tried (GitHub organisation) it didn't load the icon in command palette but that's because it was using the IconSet API and not symbols which isn't supported by command palette right now (cc @janfaracik )
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires jenkinsci/branch-api-plugin#497 to be taken out of draft
Part of jenkinsci/jenkins#10049 but can be merged interdependently
Proposed changelog entries
Submitter checklist
* Use the
Internal:prefix if the change has no user-visible impact (API, test frameworks, etc.)