Add icons to Command Palette

[janfaracik]

Medium-ish PR to add icons to the newly introduced Command Palette. This is one of the first refinements to search, with the intention of making search more useful and visual for users. Actions can override getSearchIcon() to add an icon, or if they implement IconSpec getSearchIcon() will use that by default.

Big thanks to @timja for help on this :)

Testing done

• Icons show in the Command Palette
• Bitmaps also show (e.g. user avatars)

Proposed changelog entries

• Add icons to Command Palette

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

1. The Jira issue, if it exists, is well-described.
2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
3. There is automated testing or an explanation as to why this change has no tests.
4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
8. For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[timja]

@janfaracik add the rfe changelog for a minor enhancement to changelog.

web-ui is just for filtering for people interested it doesn't do anything itself

[jtnord]

I guess this comment is relevant here.
Why is IconSpec javadoc not being updated if it is no longer just for Actions/ManagementLinks?

[timja]

I guess this comment is relevant here. Why is IconSpec javadoc not being updated if it is no longer just for Actions/ManagementLinks?

done

[github-actions]

Please take a moment and address the merge conflicts of your pull request. Thanks!

[timja]

LGTM, (tested locally)

[krisstern]

Looks okay to me too!

[timja]

Looks like a test is failing consistently on this @janfaracik ?

[krisstern]

Yeah, I see the following in the logs:

19:31:19  [INFO] Results:
19:31:19  [INFO] 
19:31:19  [ERROR] Failures: 
19:31:19  [ERROR]   AbstractProjectTest.autoCompleteUpstreamProjects:630->testAutoCompleteResponse:669 
19:31:19  Expected: is <true>
19:31:19       but: was <false>
19:31:19  [INFO] 
19:31:19  [ERROR] Tests run: 2212, Failures: 1, Errors: 0, Skipped: 55
19:31:19  [INFO] 
19:31:19  [ERROR] There are test failures.
19:31:19  
19:31:19  See /home/jenkins/agent/workspace/Core_jenkins_PR-10049/test/target/surefire-reports for the individual test results.

[timja]

/label ready-for-merge

---

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

[krisstern]

It looks like we also have a NullPointerException according to the logs at https://github.com/jenkinsci/jenkins/pull/10049/checks?check_run_id=34386281462:

java.lang.NullPointerException: Cannot invoke "org.htmlunit.html.DomElement.getHtmlElementDescendants()" because "doc" is null
	at org.htmlunit.html.HtmlPage.executeDeferredScriptsIfNeeded(HtmlPage.java:1466)
	at org.htmlunit.html.HtmlPage.initialize(HtmlPage.java:265)
	at org.htmlunit.WebClient.loadWebResponseInto(WebClient.java:701)
	at org.htmlunit.WebClient.loadWebResponseInto(WebClient.java:575)
	at org.htmlunit.WebClient.getPage(WebClient.java:493)
	at org.htmlunit.WebClient.getPage(WebClient.java:402)
	at org.htmlunit.WebClient.getPage(WebClient.java:538)
	at org.htmlunit.WebClient.getPage(WebClient.java:520)
	at org.jvnet.hudson.test.JenkinsRule$WebClient.getPage(JenkinsRule.java:2735)
	at org.jvnet.hudson.test.JenkinsRule.after(JenkinsRule.java:518)
	at org.jvnet.hudson.test.JenkinsRule$1.evaluate(JenkinsRule.java:676)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.lang.Thread.run(Thread.java:840)

Also one seen at https://ci.jenkins.io/job/Core/job/jenkins/job/PR-10049/7/:

02:14:48  [ERROR]   FileParameterValueTest.fileParameter_canStillUse_internalHierarchy » NullPointer Cannot invoke "org.htmlunit.html.DomElement.getHtmlElementDescendants()" because "doc" is null
02:14:48  [INFO] 
02:14:48  [ERROR] Tests run: 2212, Failures: 0, Errors: 1, Skipped: 55
02:14:48  [INFO] 
02:14:48  [ERROR] 

[timja]

(nonblocking as pre-existing, but can potentially be enhanced in a followup)

One pre-existing issue is that items with a display name are found twice, (even when the actual name is nothing alike)

But the display name version isn't an instanceof Item, which means it just gets the default icon.

Ideally it wouldn't report twice or at least it would provide the right item.

See pre-existing screenshot from ci.jenkins.io:

[timja]

/label ready-for-merge

---

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!