Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-63254][JENKINS-47101] Watch sensitive variables #105

Merged
merged 14 commits into from
Oct 14, 2020
Merged

[JENKINS-63254][JENKINS-47101] Watch sensitive variables #105

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
f6078c8
Register overrides for poc
car-roll Jul 24, 2020
b70cd0d
poc 2 that uses callback
car-roll Jul 28, 2020
e4399da
remove callbacks
car-roll Jul 31, 2020
76a4d8c
clean up pom, add incremental
car-roll Jul 31, 2020
a03d1b9
revert jenkins version, remove test
car-roll Jul 31, 2020
5efa464
bump jenkins version
car-roll Jul 31, 2020
9646ad3
match step-api version
car-roll Jul 31, 2020
e14c268
implement watched variables here instead of environmentexpander
car-roll Aug 4, 2020
8c9bfdc
use updated api
car-roll Aug 4, 2020
984f29f
update step-api incremental, address review comments
car-roll Sep 15, 2020
2fd9f78
Merge remote-tracking branch 'upstream/master' into binding-callback
car-roll Sep 15, 2020
06428a0
simplify
car-roll Sep 16, 2020
09ad308
update to released workflow-step-api
car-roll Oct 14, 2020
981a324
Update bom
car-roll Oct 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,9 @@
<properties>
<revision>1.24</revision>
<changelist>-SNAPSHOT</changelist>
<jenkins.version>2.164.3</jenkins.version>
<jenkins.version>2.176.4</jenkins.version>
jglick marked this conversation as resolved.
Show resolved Hide resolved
<java.level>8</java.level>
<workflow-step-api.version>2.23-rc567.0fe52fbdf6b5</workflow-step-api.version>
jglick marked this conversation as resolved.
Show resolved Hide resolved
</properties>
<licenses>
<license>
Expand Down Expand Up @@ -73,6 +74,7 @@
<dependency>
<groupId>org.jenkins-ci.plugins.workflow</groupId>
<artifactId>workflow-step-api</artifactId>
<version>${workflow-step-api.version}</version>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
Expand Down Expand Up @@ -111,6 +113,7 @@
<dependency>
<groupId>org.jenkins-ci.plugins.workflow</groupId>
<artifactId>workflow-step-api</artifactId>
<version>${workflow-step-api.version}</version>
<classifier>tests</classifier>
<scope>test</scope>
</dependency>
Expand Down
3 changes: 3 additions & 0 deletions src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,9 @@ private static final class Overrider extends EnvironmentExpander {
}
}

@Override public Set<String> getSensitiveVariables() {
return Collections.unmodifiableSet(overrides.keySet());
}
}

/** Similar to {@code MaskPasswordsOutputStream}. */
Expand Down