[JENKINS-63254][JENKINS-47101] Watch sensitive variables #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
car-roll
force-pushed
the
binding-callback
branch
from
190aacd
to
5440970
Compare
car-roll
changed the title
car-roll
force-pushed
the
binding-callback
branch
from
2a8e803
to
5efa464
Compare
dwnusbaum
reviewed
Aug 5, 2020
src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep.java
Outdated
Show resolved
Hide resolved
dwnusbaum
reviewed
Sep 16, 2020
src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep.java
Outdated
Show resolved
Hide resolved
dwnusbaum
approved these changes
Sep 21, 2020
bitwiseman
approved these changes
Sep 23, 2020
car-roll
changed the title
jglick
reviewed
Oct 14, 2020
jglick
requested changes
Oct 14, 2020
jglick
approved these changes
Oct 14, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-63254
PoC version 2 for groovy string interpolation interception.
Relies on changes to
EnvironmentExpander. Unlike version 1, does not require any changes to core.Requires: jenkinsci/workflow-step-api-plugin#57
Upstream: jenkinsci/workflow-cps-plugin#370
TODO:
- Add unit test(s)CC @dwnusbaum @bitwiseman