Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-63254][JENKINS-47101] add watch variables to EnvironmentExpander #57

Merged
merged 5 commits into from
Oct 14, 2020
Merged

[JENKINS-63254][JENKINS-47101] add watch variables to EnvironmentExpander #57

merged 5 commits into from
Oct 14, 2020

Conversation

car-roll
Copy link
Contributor

@car-roll car-roll commented Jul 28, 2020 •
edited
Loading

JENKINS-63254

Enable EnvironmentExpander to track sensitive variables

Upstream of:
jenkinsci/credentials-binding-plugin#105
jenkinsci/workflow-cps-plugin#370

cc @dwnusbaum @bitwiseman

This was referenced Jul 28, 2020
Merged
Merged
@car-roll car-roll changed the title add call back to environmentexpander [JENKINS-63254] add watch variables to EnvironmentExpander Jul 31, 2020
@car-roll car-roll closed this Aug 4, 2020
@car-roll car-roll reopened this Aug 4, 2020
@car-roll
Copy link
Contributor Author

car-roll commented Aug 4, 2020

Incrementals failed, bouncing

@car-roll car-roll closed this Aug 4, 2020
@car-roll car-roll reopened this Aug 4, 2020
@car-roll car-roll closed this Aug 4, 2020
@car-roll car-roll reopened this Aug 4, 2020
@jglick jglick self-requested a review August 19, 2020 16:53
@car-roll car-roll marked this pull request as ready for review September 11, 2020 06:15
dwnusbaum
dwnusbaum approved these changes Sep 14, 2020
View reviewed changes
Copy link
Member

@dwnusbaum dwnusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some minor suggestions, but the main idea looks good to me.

src/main/java/org/jenkinsci/plugins/workflow/steps/EnvironmentExpander.java Outdated Show resolved Hide resolved
@car-roll
Copy link
Contributor Author

bump for ci

@car-roll car-roll closed this Sep 15, 2020
@car-roll car-roll reopened this Sep 15, 2020
@car-roll car-roll closed this Sep 15, 2020
@car-roll car-roll reopened this Sep 15, 2020
@car-roll
Copy link
Contributor Author

"re-run" option doesn't really seem to be working. Going back to the old ways...

@car-roll car-roll closed this Sep 15, 2020
@car-roll car-roll reopened this Sep 15, 2020
@car-roll car-roll closed this Sep 15, 2020
@car-roll car-roll reopened this Sep 15, 2020
@car-roll car-roll changed the title [JENKINS-63254] add watch variables to EnvironmentExpander [JENKINS-63254][JENKINS-47101] add watch variables to EnvironmentExpander Sep 29, 2020
@car-roll car-roll merged commit 4b67af1 into jenkinsci:master Oct 14, 2020
@dwnusbaum dwnusbaum mentioned this pull request Nov 5, 2020
Merged
This was referenced Mar 11, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwnusbaum dwnusbaum dwnusbaum approved these changes

@bitwiseman bitwiseman bitwiseman approved these changes

@jglick jglick Awaiting requested review from jglick

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@car-roll @dwnusbaum @bitwiseman