[JENKINS-47101] Add a default EnvironmentExpander that registers password parameters as sensitive variables #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwnusbaum
commented
Nov 5, 2020
| @@ -97,6 +104,9 @@ | |||
| return castOrNull(key,getExecution()); | |||
| } else if (FlowNode.class.isAssignableFrom(key)) { | |||
| return castOrNull(key, getNode()); | |||
| } else if (key == EnvironmentExpander.class) { | |||
| // Only called when `value == null` so that it does not override expanders contributed by steps. | |||
| return key.cast(new PasswordParameterEnvironmentExpander(get(Run.class))); | |||
There was a problem hiding this comment.
For now we just have single default implementation since I cannot think of any other similar cases to password parameters. If there are similar cases, maybe we should create an extension point for marking sensitive variables that are active from the start of the build or something.
dwnusbaum
commented
Nov 5, 2020
src/main/java/org/jenkinsci/plugins/workflow/support/DefaultStepContext.java
Outdated
Show resolved
Hide resolved
…word parameters as sensitive variables
dwnusbaum
force-pushed
the
JENKINS-47101
branch
from
3e4ba31
to
b142593
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-47101.
Before the fix for JENKINS-47101 in jenkinsci/workflow-cps-plugin#370, password parameters would have been masked in step arguments, so I think we need to make sure that they continue to be masked, which requires us to integrate with the new API from jenkinsci/workflow-step-api-plugin#57.
We need to add a test for this case over in
workflow-cps.