use header taglib to decouple from core #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by using the header taglib any changes done there e.g. in the searchbox or the login, are automatically reused and double maintenance is avoided. Please enter the commit message for your changes. Lines starting
timja
reviewed
May 21, 2024
timja
reviewed
May 21, 2024
...n/resources/io/jenkins/plugins/customizable_header/headers/JenkinsHeader/headerContent.jelly
Outdated
Show resolved
Hide resolved
timja
reviewed
May 21, 2024
| <template id="custom-header-icons"> | ||
| <l:icon id="external-link" src="symbol-open-outline plugin-ionicons-api" class="icon-xs"/> | ||
| </template> | ||
| <header id="header" class="page-header custom-header__page"> | ||
| <header id="page-header" class="page-header custom-header__page"> |
There was a problem hiding this comment.
adjusted to match core as jenkinsci/jenkins#7569 was going to use it, although I removed the hard dependency on it there in jenkinsci/jenkins@6092031 there is at least one other reference to it
14 tasks
|
Anything holding this up? |
mawinter69
force-pushed
the
use-header-taglib
branch
from
caa9674
to
87d83a7
Compare
timja
approved these changes
Jul 13, 2024
There was a problem hiding this comment.
I tested this earlier quite thoroughly with this PR jenkinsci/jenkins#7569
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since 2.459 core provides the logo, search box and login parts of the header via a taglib for easier reuse in plugins.
This avoids that we have to duplicate the code and do double maintenance.
Testing done
Submitter checklist