Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move the header parts in a taglib #9223

Merged
merged 1 commit into from
May 18, 2024

Conversation

mawinter69
Copy link
Contributor

@mawinter69 mawinter69 commented May 2, 2024

the taglib allows plugins to make use of the searchbox and the login stuff while easily being able to modify all the other aspects of the header.

Testing done

Manually verified that the header is not modified. Also in the downstream PR using the taglib works without problems.

see jenkinsci/customizable-header-plugin#101

Proposed changelog entries

  • Provide header parts as a tag library.

Proposed upgrade guidelines

N/A

Submitter checklist

Before the changes are marked as ready-for-merge:

Maintainer checklist

the taglib allows plugins to make use of the searchbox and the login
stuff while easily being able to modify all the other aspects of the
header.
Comment on lines +4 to +6
<h:logo/>
<h:searchbox/>
<h:login/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now public API. Are we confident a redesign doesn't just randomly change this anytime soon?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any substantial change to the header would require a change of the header version in the PartialHeader so that plugins need to react. I might need to stick to the PartialHeader in the PR of my plugin (which is so far the only implementation of a header) https://github.com/jenkinsci/customizable-header-plugin/blob/295683015391e800be41c568b42ac80f6fd7c61b/src/main/java/io/jenkins/plugins/customizable_header/headers/LogoHeader.java#L9

@timja timja added developer Changes which impact plugin developers rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels May 8, 2024
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, downstream changes look good

@timja timja requested a review from a team May 9, 2024 06:50
@timja
Copy link
Member

timja commented May 11, 2024

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label May 11, 2024
@MarkEWaite MarkEWaite merged commit c0c1999 into jenkinsci:master May 18, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer Changes which impact plugin developers ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants