-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ARM64 Java in JDK17 Bullseye #310
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Formatting suggestions only)
Co-authored-by: Hervé Le Meur <91831478+lemeurherve@users.noreply.github.com>
Co-authored-by: Hervé Le Meur <91831478+lemeurherve@users.noreply.github.com>
Co-authored-by: Hervé Le Meur <91831478+lemeurherve@users.noreply.github.com>
Co-authored-by: Hervé Le Meur <91831478+lemeurherve@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks! This is really a nice job!
However, there are 2 (minor but blocking) changes to be made:
- The
target
field should be set outside theargs blocks
- The
LABEL
filed in the `Dockerfile should be moved to the "common" debian stage.
Co-authored-by: Bruno Verachten <gounthar@gmail.com>
Co-authored-by: Bruno Verachten <gounthar@gmail.com>
Co-authored-by: Bruno Verachten <gounthar@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work!
… not Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
fix(debian_jdk17) revert #310 and use `TARGETPLATFORM` to detect if arm/v7 or not
Fixes #308. Use platform dependent image by default to get correct java runtime.
Use native java runtime when on arm32 to get around jmods error:
"jmods: Value too large for defined data type" error
Link to relevant pull requests, esp. upstream and downstream changesEnsure you have provided tests - that demonstrates feature works or fixes the issue