fix(debian_jdk17) revert #310 and use TARGETPLATFORM
to detect if arm/v7 or not
#324
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #323 and #308.
This PR reverts #310 and fixes #308 with a similar approach but with the "conditionnality" of the
arm/v7
directly inside theDockerfile
'sjre-build
stage.While reading https://www.docker.com/blog/faster-multi-platform-builds-dockerfile-cross-compilation-guide/, I confirmed @carpnick 's analysis about the
BUILDPLATFORM
. But it seems that Docker provides another variable which isTARGETPLATFORM
which is populated with the value we expect.https://docs.docker.com/engine/reference/builder/#automatic-platform-args-in-the-global-scope shows the documentation reference with an exemple on "how to" use this variable as a build argument: is is what this PR does.
Tested locally with a local registry and a "smoke test":