install-plugins uses JENKINS_UC_DOWNLOAD if specified

[nhojpatrick]

To speed up testing plugins I setup a local web server with the plugins I was using. So I tried to get JENKINS_UC_DOWNLOAD working. Due to the current logic, if you specify JENKINS_UC_DOWNLOAD, it doesn't ever get used as JENKINS_UC_LATEST will get set 1st and always used.

Taking this example Dockerfile;

FROM jenkins/jenkins:lts
ENV JENKINS_UC_DOWNLOAD https://updates.jenkins.io/download
RUN /usr/local/bin/install-plugins.sh  greenballs

The current version will download from https://updates.jenkins.io/dynamic-2.319//latest/greenballs.hpi

The patched version will download from https://updates.jenkins.io/download/plugins/greenballs/latest/greenballs.hpi

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[MarkEWaite]

I'd much rather that people switch to use the plugin installation manager tool (wrapped in the jenkins-plugin-cli.sh file) rather than make changes to the install-plugins.sh script. The script is deprecated and lacks features that are available in the replacement.

[timja]

We only accept changes to this script if it's completely broken.

Please switch to the plugin manager cli https://github.com/jenkinsci/plugin-installation-manager-tool

docker/install-plugins.sh

Line 23 in 4fe20c4

echo "WARN: install-plugins.sh is deprecated, please switch to jenkins-plugin-cli"

[nhojpatrick]

I'm using a jenkins image provided by openshift and jenkins-plugin-cli is not packaged/avaliable but install-plugins.sh is. Also do most builds via openshift so never actually saw that WARN before your comment above.

For my reference where is jenkins-plugin-cli.sh/ps1 maintainered? So if submit a pr for RedHat, I point them to the root source to include in the offerings.

[timja]

Wrapper script:
https://github.com/jenkinsci/docker/blob/master/jenkins-plugin-cli.sh

Sources:
https://github.com/jenkinsci/plugin-installation-manager-tool

[nhojpatrick]

Thanks for details @timja will see if I can sort out OpenShift's image stream.