Use JENKINS_UC_DOWNLOAD_URL if provided

[nhojpatrick]

Fixes #415

The current code ignores JENKINS_UC_DOWNLOAD_URL if specified, as logic above will always result in something else being checked. Other if/else statements might also need to be changed to fix other issues with that logic.

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[timja]

I think ok

[timja]

can you take a look at the tests?

[nhojpatrick]

can you take a look at the tests?

Happy too, I've no time until weekend probably but will be looking at them then. Wanted to get it raised and review then fix tests.

[nhojpatrick]

Fixing the same issue as highlighted here jenkinsci/docker#1299

[nhojpatrick]

I've found time.
To make testing easier I've added JUnit v5 and assertAll to all errors show.
I've updated so if you define JENKINS_UC_DOWNLOAD_URL it's used for everything, so a true global override.

[nhojpatrick]

Converting to draft and rebase from PR #417 so this PR easier to understand what has changed when using assertAll to improve dev/test cycles.

[julien-demaziere]

LGTM
I ran the tests successfully on my PC with java 11

[sichapman]

Any chance of having this merged? Being able to use JENKINS_UC_DOWNLOAD_URL the way it is documented would be extremely useful

[MarkEWaite]

Thanks very much @timja ! Will the jar file be published to the GitHub release automatically or is there some other step needed?

[timja]

It will be I got distracted and didn't publish the release at the time, it should be attached here soon: https://github.com/jenkinsci/plugin-installation-manager-tool/releases/tag/2.13.1

[MarkEWaite]

It will be I got distracted and didn't publish the release at the time, it should be attached here soon: https://github.com/jenkinsci/plugin-installation-manager-tool/releases/tag/2.13.1

Thanks. I could have published that GitHub release page myself and that would have solved it. I didn't even think of that. Sorry that I didn't do my part to help! Thanks for doing the release!

[cronik]

This change breaks all current usages where there is a plugin specific url defined in the plugin spec. Wouldn't it make more sense for the precedence to prefer the plugin url then use the download url if available?