[JENKINS-58578] Force the setting of the private ip also for public subnet #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should probably also be updated in the |
|
Is this unit testable? |
jvz
approved these changes
Aug 15, 2019
res0nance
approved these changes
Aug 20, 2019
| @@ -633,11 +633,12 @@ private void logProvisionInfo(String message) { | |||
| } | |||
| } | |||
|
|
|||
| net.setAssociatePublicIpAddress(false); | |||
There was a problem hiding this comment.
Suggested change
| net.setAssociatePublicIpAddress(false); | |
| net.setAssociatePublicIpAddress(getAssociatePublicIp()); |
Will allow you to remove the if
| @@ -946,11 +947,12 @@ private void setupCustomDeviceMapping(List<BlockDeviceMapping> deviceMappings) { | |||
| launchSpecification.setKeyName(keyPair.getKeyName()); | |||
| launchSpecification.setInstanceType(type.toString()); | |||
|
|
|||
| net.setAssociatePublicIpAddress(false); | |||
There was a problem hiding this comment.
Suggested change
| net.setAssociatePublicIpAddress(false); | |
| net.setAssociatePublicIpAddress(getAssociatePublicIp()); |
Same here
varyvol
approved these changes
Sep 25, 2019
|
Do you think this could be merged? |
res0nance
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-58578 Force the setting of the private ip also for public subnet