[JENKINS-59459] Revert both fields from being transient #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's this change for? Is it to allow older versions of the plugin to use a template saved by a newer version? @varyvol |
|
@MRamonLeon precisely that. |
varyvol
changed the title
|
Fixes a backwards compatibility introduced in #329 for reference |
res0nance
approved these changes
Sep 20, 2019
fcojfernandez
approved these changes
Sep 20, 2019
|
I included an automated test. By the way this is related with JENKINS-59460 too. |
fcojfernandez
approved these changes
Sep 20, 2019
There was a problem hiding this comment.
Thanks for the test @varyvol !
@res0nance , would you like to review the test as well?
jvz
approved these changes
Sep 20, 2019
|
@res0nance I think this can be merged. |
|
Merged thanks @varyvol |
|
@res0nance thanks! Do you know if there are plans to deliver a new release soon? I think delivering this and #387 is interesting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-59459
Revert both fields from being transient so that they are exported and thus older version of the plugins are still able to import the template.
@dgarzon