Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StrictHostKeyChecking=off should be StrictHostKeyChecking=no #455

Merged

Conversation

cmacgreg
Copy link
Contributor

@cmacgreg cmacgreg commented May 7, 2020

This plugin was upgraded on our Jenkins server, and we were unaware of the host key requirement changes (and our AMIs are incompatible without some extra effort). We were unable to continue without downgrading, because the SSH syntax for the "off" option is incorrect, leading to the following error, even when the "Host Key Verification Strategy" was set to off:

$ ssh -o StrictHostKeyChecking=off -i /var/lib/jenkins/tmp/ec2_4085601235825214564.pem jenkins@172.33.200.99 -p 22  java -Dfile.encoding=UTF8 -jar /tmp/remoting.jar -workDir /jenkins
command-line line 0: unsupported option "off".

It should be -o StrictHostKeyChecking=no

(we have every intention of fixing the AMIs, and the new feature makes sense, but we like to keep our Jenkins plugins relatively up-to-date, and breaking changes with more restrictive defaults make this difficult)

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to get it shipped

Copy link
Contributor

@MRamonLeon MRamonLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants