-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-62231] Move start logic to postInitialize to avoid OldDataMo… #464
[JENKINS-62231] Move start logic to postInitialize to avoid OldDataMo… #464
Conversation
// backward compatibility with the legacy instance type | ||
Jenkins.XSTREAM.registerConverter(new InstanceTypeConverter()); | ||
|
||
load(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe just load()
is needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good, but not tested
The build is failing because the recommendedConfiguration uses jenkins.version=2.164.1 and we updated jenkins.version to 2.176.4. We should use a different configuration or revert the bump of the jenkins.version. @res0nance at this point, taking into account the discussion about
I will try in a new commit, not sure if I have the rights to do that. |
I believe my changes on Jenkinsfile wasn't taken into account |
There seems to be an issue on windows as well, I'll work on it later, right now I'm trying to get the builds going again quickly |
@res0nance would you be able to cut a release with #455 and other improvements? To avoid pain on people upgrading with old ssh clients. |
See JENKINS-62231 for full story
To avoid the plugin to fail when loading its configuration if any modification has been done we move the logic from
start
topostInitialize
method. It may help for future versions upgrade/downgrade ability.@res0nance @fcojfernandez @alecharp @varyvol @rsandell ARggghhhh I cannot even request reviewers