Add retry logic for connection timeout exception #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could a test be added for this? |
|
I added some testing for the CloudHelper class as requested. |
|
@res0nance Any chance this could be merged now that tests have been added |
|
@froblesmartin @res0nance Could I get some eyes on this when you get a chance? I've updated the pull request as requested |
res0nance
approved these changes
Feb 23, 2021
res0nance
approved these changes
Apr 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a private jenkins server we were experiencing a problem where the EC2SlaveMonitor would query aws for an agent and get a response code with the error code 'RequestExpired'. This would result in the slave monitor deleting the agents from jenkins but the instances were still running within aws. Worse the orphaned agents would still count towards the instance cap and eventually prevent us from spinning up additional agents when required.
Adding the timeout condition to the retry logic resolved this problem for us.