Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect an expired request exception #560

Merged
merged 1 commit into from
May 2, 2022

Conversation

suthsc
Copy link
Contributor

@suthsc suthsc commented Jan 22, 2021

JENKINS-63537 - EC2SlaveMonitor terminates agent with a running job when STS session expires

  • Add conditional logic to skip removal of nodes when RequestExpiredPredicate.test(AmazonClientException) returns true

This pull request is an alternative implementation to #493 as proposed @MRamonLeon. I am working on including tests for the new functionality.

@suthsc suthsc force-pushed the expired-request-exception-check branch from 2a8ddd3 to 49f0029 Compare April 19, 2021 20:38
@suthsc suthsc mentioned this pull request Apr 19, 2021
@suthsc suthsc force-pushed the expired-request-exception-check branch from 37d2e45 to 358fa7b Compare July 9, 2021 15:02
@suthsc
Copy link
Contributor Author

suthsc commented Jul 9, 2021

Might be related to #515

@suthsc suthsc force-pushed the expired-request-exception-check branch from 358fa7b to ddef5c9 Compare September 15, 2021 19:30
@suthsc suthsc force-pushed the expired-request-exception-check branch from ddef5c9 to 49e793d Compare December 14, 2021 04:03
* Defined a constant EC2_REQUEST_EXPIRED_ERROR_CODE with the error code string
* Replaced hard coded string with constant in CloudHelper check
* Conditional logic in EC2SlaveMonitor to skip node termination when the cause is RequestExpired
@suthsc suthsc force-pushed the expired-request-exception-check branch from 49e793d to e193d5f Compare April 29, 2022 15:37
@res0nance res0nance merged commit d6c1b24 into jenkinsci:master May 2, 2022
@suthsc suthsc deleted the expired-request-exception-check branch June 23, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants