Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-64147] Forwards compat with table-to-div #528

Merged
merged 3 commits into from
Nov 6, 2020
Merged

[JENKINS-64147] Forwards compat with table-to-div #528

merged 3 commits into from
Nov 6, 2020

Conversation

res0nance
Copy link
Contributor

Still broken on < 2.264 but seems to work on the newest versions.

Not sure what the issue is, any idea @timja

@res0nance res0nance changed the title Forwards compat with table-to-div [JENKINS-64147] Forwards compat with table-to-div Nov 5, 2020
@timja
Copy link
Member

timja commented Nov 5, 2020

reproduced, looking

@timja
Copy link
Member

timja commented Nov 5, 2020

You're missing the taglib marker file

$ git diff --cached
diff --git a/src/main/resources/lib/ec2/taglib b/src/main/resources/lib/ec2/taglib
new file mode 100644
index 0000000..e69de29
 timja at Frankel in ~/projects/jenkinsci/ec2-plugin on table-to-div*
$ git status
On branch table-to-div
Changes to be committed:
  (use "git restore --staged <file>..." to unstage)
	new file:   src/main/resources/lib/ec2/taglib

fixes it

https://github.com/res0nance/ec2-plugin/pull/6

@res0nance res0nance marked this pull request as ready for review November 6, 2020 04:22
@res0nance res0nance requested a review from timja November 6, 2020 04:23
@res0nance res0nance merged commit dac2e7e into jenkinsci:master Nov 6, 2020
@res0nance res0nance deleted the table-to-div branch November 6, 2020 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants