[JENKINS-60482] Persist the alternate ec2 endpoint #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It helps when the default url is forbidden, you don't need to set it every time you access the configure clouds page.
MRamonLeon
requested review from
res0nance,
fcojfernandez,
froblesmartin,
rsandell and
alecharp
fcojfernandez
approved these changes
Nov 24, 2020
res0nance
approved these changes
Nov 24, 2020
|
I've added a new test @res0nance , fine to you? |
res0nance
approved these changes
Nov 24, 2020
Looks good |
alecharp
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://issues.jenkins-ci.org/browse/JENKINS-60482
Simplified version of #439
Reasoning:
The field
Alternate EC2 endpointhas only one purpose, to fill up theRegionfield. If you're in an environment where the default endpoint is not reachable, you can specify here the full url to use instead. Like:https://ec2.us-west-1.amazonaws.com. Once the field is populated, the connection and all other operations are performed using this region, so they should go fine.It's true that every time you enter the configuration page, the
Alternate EC2 endpointis empty, so theRegionfield never gets populated until you set the endpoint properly. So it causes a lot of frustration and misunderstanding, IMO.This PR tries to resolve the problem by persisting this field, so every time you reach the configuration page, the field is established, so the region field is populated correctly. This PR is simpler than #439 where we use the
Alternate EC2 endpointas the full new AWS endpoint (IIUC), which I think it's not necessary.I've recorded a video to show the behavior: https://photos.app.goo.gl/aADg5roUcKbMqLKj8
CC: @jkfernan @GaToRAiD @troymohl