Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-60482] Improve alternate ec2 point checks #539

Conversation

MRamonLeon
Copy link
Contributor

Follow up on #537 (JENKINS-60482) to better manage errors when setting the Alternate EC2 endpoint.

If the URL is wrong, you get an angry Jenkins on the field row:

Screenshot from 2020-11-24 16-50-08

With this PR it's not displayed and you get an error message behind the field:
image

Log:

2020-11-24 15:38:10.712+0000 [id=81]    WARNING h.p.e.AmazonEC2Cloud$DescriptorImpl#determineEC2EndpointURL: The alternate EC2 endpoint is malformed (https.//ec2.us-east-1.amazonaws.com). Using the default endpoint (https://ec2.amazonaws.com)

Once you fix the wrong URL (In the image by removing the https. by https:), it works:
image

@MRamonLeon MRamonLeon merged commit 6712bf5 into jenkinsci:master Nov 24, 2020
@MRamonLeon MRamonLeon deleted the JENKINS-60482-improve-alt-endpoint-checking branch November 24, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants