[JENKINS-61161] Avoid infamous UI connection strategy warning #538

MRamonLeon · 2020-11-24T13:26:09Z

See https://issues.jenkins.io/browse/JENKINS-61161

Avoid the ugly and erroneous Could not find selected connection strategy every time one changes the connection strategy.

See:

MRamonLeon · 2020-11-24T13:27:10Z

src/main/java/hudson/plugins/ec2/SlaveTemplate.java

@@ -2040,7 +2040,7 @@ public ListBoxModel doFillConnectionStrategyItems(@QueryParameter String connect

        public FormValidation doCheckConnectionStrategy(@QueryParameter String connectionStrategy) {
            return Stream.of(ConnectionStrategy.values())
-                    .filter(v -> v.equalsName(connectionStrategy))
+                    .filter(v -> v.name().equals(connectionStrategy))


Previously: Public_IP == PUBLIC_IP ??

Now: PUBLIC_IP == PUBLIC_IP ??

See:

ec2-plugin/src/main/java/hudson/plugins/ec2/ConnectionStrategy.java

Line 5 in 2f348aa

PUBLIC_IP("Public IP"),

is it not the same? why is it fixing the error?

ec2-plugin/src/main/java/hudson/plugins/ec2/ConnectionStrategy.java

Lines 15 to 17 in 2f348aa

public boolean equalsName(String other) {

return this.name.equals(other);

}

I too am interested in Francisco's point

equalsName is comparing the text added in the constructor (Public IP lowercase) as you can see above, but the connectionStrategy variable contains the declared name of the enum (PUBLIC IP uppercase), so they were never equals. With name() we use the declared name.

Oh! I see now! Really good point Ramon

~~Interesting, then shouldn't equals() also produce the desired behaviour?~~
Edit: Forgot the the other object is simply a string, LGTM. thanks for the explaination

fcojfernandez · 2020-11-25T08:15:40Z

src/main/java/hudson/plugins/ec2/SlaveTemplate.java

@@ -2040,7 +2040,7 @@ public ListBoxModel doFillConnectionStrategyItems(@QueryParameter String connect

        public FormValidation doCheckConnectionStrategy(@QueryParameter String connectionStrategy) {
            return Stream.of(ConnectionStrategy.values())
-                    .filter(v -> v.equalsName(connectionStrategy))
+                    .filter(v -> v.name().equals(connectionStrategy))


Oh! I see now! Really good point Ramon

amedee · 2021-04-13T12:20:51Z

Regression? I have this error again in EC2 plugin version 1.56

jensenbox · 2021-04-22T05:56:56Z

I can corroborate - this is still an issue. We use CasC and it will not work under any condition. The knock on effect is that after a configuration update and restart of Jenkins, no EC2 instance can be created. Perhaps the logic of this validation function is flawed? Frankly I do not mind seeing the actual enum value show up in as the form value PUBLIC_IP - it gives a clear understanding of the underlying value. So perhaps just yank the name property - it would sure make translations that much better too (do not compare the human value to the internal value) - just spitballing here as this is a real pain.

radnov · 2021-06-02T09:30:15Z

This is still an issue in 1.59 🤕

@amedee, @jensenbox Have you guys found any intermediate solution to this?

Doing "Apply" on the Clouds configuration from the UI "fixes" the Connection Strategy problem. Having to POST $JENKINS_URL/configureClouds/configure on each JCasC reload is just nasty.

res0nance · 2021-06-02T10:37:25Z

This is still an issue in 1.59 🤕

@amedee, @jensenbox Have you guys found any intermediate solution to this?

Doing "Apply" on the Clouds configuration from the UI "fixes" the Connection Strategy problem. Having to POST $JENKINS_URL/configureClouds/configure on each JCasC reload is just nasty.

I can recreate the issue when adding a new template which is fixed in #626

radnov · 2021-06-02T11:34:02Z

@jensenbox See this comment in case you're still facing the JCasC issue. 👍

amedee · 2021-06-02T22:39:11Z

As of 8 hours and 39 minutes ago, I no longer work at the company where we had this issue. I no longer have access to the Jenkins there so I can't check the configuration. I am unable to help you, sorry.

…

On 2/06/2021 11:30, radnov wrote: This is still an issue in 1.59 🤕 @amedee <https://github.com/amedee>, @jensenbox <https://github.com/jensenbox> Have you guys found any intermediate solution to this? Doing "Apply" on the Clouds configuration from the UI "fixes" the Connection Strategy problem. Having to |POST $JENKINS_URL/configureClouds/configure| on each JCasC reload is just nasty. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#538 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADRIWPXNBK7HFDAGMIVH5DTQX23PANCNFSM4UA4KZEA>.

albertodebortoli · 2021-06-04T08:15:50Z

This is more broken now with 1.60 than before. I literally tried every possible combination of fields but the connection strategy always falls back to "Public DNS".

res0nance · 2021-06-04T09:42:58Z

This is more broken now with 1.60 than before. I literally tried every possible combination of fields but the connection strategy always falls back to "Public DNS".

Fixed in #627 has to do with a weird issue where the name of the variable was causing issues. I tested it locally and it seems to be fine now even when saving and loading. Will be making a new release 1.60.1 for this

[JENKINS-61161] Avoid infamous UI connection strategy warning

e7fdf4d

MRamonLeon requested review from fcojfernandez, res0nance, froblesmartin, rsandell and alecharp November 24, 2020 13:26

MRamonLeon commented Nov 24, 2020

View reviewed changes

alecharp approved these changes Nov 24, 2020

View reviewed changes

res0nance added the bugfix label Nov 24, 2020

fcojfernandez approved these changes Nov 25, 2020

View reviewed changes

res0nance approved these changes Nov 25, 2020

View reviewed changes

MRamonLeon merged commit 1bd695f into jenkinsci:master Nov 25, 2020

MRamonLeon deleted the JENKINS-61161 branch November 25, 2020 09:08

res0nance mentioned this pull request Jun 2, 2021

Fix connection strategy warning for new templates #626

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[JENKINS-61161] Avoid infamous UI connection strategy warning #538

[JENKINS-61161] Avoid infamous UI connection strategy warning #538

MRamonLeon commented Nov 24, 2020

MRamonLeon Nov 24, 2020 •

edited

Loading

fcojfernandez Nov 24, 2020

res0nance Nov 24, 2020

MRamonLeon Nov 25, 2020 •

edited

Loading

fcojfernandez Nov 25, 2020

res0nance Nov 25, 2020 •

edited

Loading

fcojfernandez Nov 25, 2020

amedee commented Apr 13, 2021

jensenbox commented Apr 22, 2021

radnov commented Jun 2, 2021

res0nance commented Jun 2, 2021

radnov commented Jun 2, 2021

amedee commented Jun 2, 2021 via email

albertodebortoli commented Jun 4, 2021

res0nance commented Jun 4, 2021

	public boolean equalsName(String other) {
	return this.name.equals(other);
	}

[JENKINS-61161] Avoid infamous UI connection strategy warning #538

[JENKINS-61161] Avoid infamous UI connection strategy warning #538

Conversation

MRamonLeon commented Nov 24, 2020

MRamonLeon Nov 24, 2020 • edited Loading

Choose a reason for hiding this comment

fcojfernandez Nov 24, 2020

Choose a reason for hiding this comment

res0nance Nov 24, 2020

Choose a reason for hiding this comment

MRamonLeon Nov 25, 2020 • edited Loading

Choose a reason for hiding this comment

fcojfernandez Nov 25, 2020

Choose a reason for hiding this comment

res0nance Nov 25, 2020 • edited Loading

Choose a reason for hiding this comment

fcojfernandez Nov 25, 2020

Choose a reason for hiding this comment

amedee commented Apr 13, 2021

jensenbox commented Apr 22, 2021

radnov commented Jun 2, 2021

res0nance commented Jun 2, 2021

radnov commented Jun 2, 2021

amedee commented Jun 2, 2021 via email

albertodebortoli commented Jun 4, 2021

res0nance commented Jun 4, 2021

MRamonLeon Nov 24, 2020 •

edited

Loading

MRamonLeon Nov 25, 2020 •

edited

Loading

res0nance Nov 25, 2020 •

edited

Loading