Fix connection strategy UI prompt #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm that this is working now in the UI. However, I still have to go into the UI and set it to another value and back before instances can actually connect. If we boot Jenkins with just CasC and let it start up as expected and try to craft a new EC2 instance, we receive the following as part of the logs:
I could be completely wrong here but it feels like the saving of the plugin settings is setting the values correctly where when booting from CasC something is misconfigured. I did a CasC dump of the configuration and there is no difference that I can see for the before save and after. |
Is every instance this way? Because this doesn't seem like a configuration issue. Is there any other stacktraces or interesting logs available? |
|
It is every instance. Every time we restart Jenkins it cannot complete the provisioning. I did just try something that might mean this is not related however - The log below is what happens on a fresh boot of Jenkins with CasC - however, just going into the Cloud Configuration and hitting "save" alone and then re-provisioning allows the instances to provision. This leads me to think that the CasC is initializing the plugin in a bad state and hitting save fixes that state. Here is a complete initialization log of an instance coming up in a bad state: |
So the interesting part of this stacktrace( thank you for providing it ) is at the end where the nullpointer exception occurs. For some reasons remoteFS() is null. Can you ensure that you set it in your JCasC configuration sets this. Similar to issue experienced by this user #626 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue seems stem from
ConnectionStrategyhaving both a name field and function which seems to cause confusion so doFillConnectionStrategy can be called with either displayText or the enum NAME we only want the name but displayText was stored in the name field. Rename to prevent this issue