-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-65127] Support IMDSv2 configuration #609
Conversation
Add metadata configuration options in the Advanced section
@@ -224,6 +230,12 @@ | |||
|
|||
public EbsEncryptRootVolume ebsEncryptRootVolume; | |||
|
|||
public Boolean metadataEndpointEnabled; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAICT these can be made private.
I should find a way to private the rest of these variables as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made these private and added getters
Looking forward to this feature. |
Also another question is the EC2 plugin's behaviour on the master. |
@@ -104,6 +108,10 @@ | |||
public final Tenancy tenancy; | |||
private String instanceType; | |||
|
|||
public final Boolean metadataEndpointEnabled; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you make these field private?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<f:entry title="${%Metadata Require HTTP Tokens}" field="metadataTokensRequired"> | ||
<f:checkbox default="false"/> | ||
</f:entry> | ||
<f:entry title="${%Metadata Put Response Hop Limit}" field="metadataHopsLimit"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any restrictions to the value in this field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1-64 per Amazon. ae7ba08
Add metadata configuration options in the Advanced section