-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JENKINS-71655: Add support for AMIs without instance metadata support #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@warrior8792 @res0nance Could you help to review this please? |
res0nance
approved these changes
Jul 26, 2023
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
After https://issues.jenkins.io/browse/JENKINS-65127 was introduced with #609, AMIs without Instance Metadata support were broken. When they were provisioned, they wouldn't get key pairs properly installed by AWS EC2 (the init script on the AMIs would get stuck on waiting to access instance-metadata).
This change introduces a new option to indicate if an AMI does not support instance metadata and thus no
InstanceMetadataOptionsRequest
will be included in the EC2 request to provision an instance.Testing done
mvn test
to make sure no other tests were broken.mvn hpi:run
to make sure the UI showed the new option for metadata supported.Submitter checklist