Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with Java 21. #901

Merged
merged 1 commit into from
Nov 12, 2023
Merged

Test with Java 21. #901

merged 1 commit into from
Nov 12, 2023

Conversation

gounthar
Copy link
Contributor

Java 21 was released Sep 19, 2023. We want to announce full support for Java 21 in early October and would like the most used plugins to be compiled and tested with Java 21.

The acceptance test harness and plugin bill of materials tests are already passing with Java 21. This is a further step to improve plugin readiness for use with Java 21 and for development with Java 21.

The change intentionally tests only two Java configurations, Java 17 and Java 21 because we believe that the risk of a regression that only affects Java 11 is shallow. We generate Java 11 byte code with the Java 17 and the Java 21 builds, so we're already testing Java 11 byte code.

Testing done

Confirmed tests pass with Java 21 on Linux.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@MarkEWaite
Copy link
Contributor

@Vlatombe it would be much appreciated if this were merged so that the plugin was regularly tested with Java 21. No release is required, just a merge

@Vlatombe
Copy link
Member

I don't have maintainership on this plugin, @res0nance does.

@MarkEWaite
Copy link
Contributor

I don't have maintainership on this plugin, @res0nance does.

Thanks @Vlatombe . My mistake.

@res0nance , @fcojfernandez , @MRamonLeon , @thoulen , or @froblesmartin would one of you be willing to merge this so that Java 21 is tested regularly with the plugin?

@res0nance res0nance merged commit 26e5e42 into jenkinsci:master Nov 12, 2023
15 checks passed
@MarkEWaite
Copy link
Contributor

Thanks @res0nance !

@gounthar gounthar deleted the jdk21 branch November 12, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants