Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-72007] Support new AWS machine types #904

Merged
merged 17 commits into from
Nov 12, 2023

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Oct 26, 2023

[JENKINS-72007] Support new AWS machine types

JENKINS-72007 asks for support of new EC2 instance types that are available with newer versions of the AWS Java SDK. I'm not a user of the AWS Java SDK, but there is a release of the new version of the API plugin that provides the new machine types.

Current pre-release

Testers verified earlier versions

Includes or supersedes the following pull requests:

Testing done

Confirmed that automated tests pass. No interactive testing

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes

dependabot bot and others added 10 commits August 8, 2023 07:46
Bumps [com.hierynomus:smbj](https://github.com/hierynomus/smbj) from 0.11.5 to 0.12.2.
- [Commits](hierynomus/smbj@v0.11.5...v0.12.2)

---
updated-dependencies:
- dependency-name: com.hierynomus:smbj
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [org.jenkins-ci.plugins:aws-credentials](https://github.com/jenkinsci/aws-credentials-plugin) from 191.vcb_f183ce58b_9 to 218.v1b_e9466ec5da_.
- [Release notes](https://github.com/jenkinsci/aws-credentials-plugin/releases)
- [Changelog](https://github.com/jenkinsci/aws-credentials-plugin/blob/master/CHANGELOG-archive.md)
- [Commits](https://github.com/jenkinsci/aws-credentials-plugin/commits)

---
updated-dependencies:
- dependency-name: org.jenkins-ci.plugins:aws-credentials
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [org.testcontainers:testcontainers](https://github.com/testcontainers/testcontainers-java) from 1.19.0 to 1.19.1.
- [Release notes](https://github.com/testcontainers/testcontainers-java/releases)
- [Changelog](https://github.com/testcontainers/testcontainers-java/blob/main/CHANGELOG.md)
- [Commits](testcontainers/testcontainers-java@1.19.0...1.19.1)

---
updated-dependencies:
- dependency-name: org.testcontainers:testcontainers
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [org.jenkins-ci.plugins:plugin](https://github.com/jenkinsci/plugin-pom) from 4.73 to 4.74.
- [Release notes](https://github.com/jenkinsci/plugin-pom/releases)
- [Changelog](https://github.com/jenkinsci/plugin-pom/blob/master/CHANGELOG.md)
- [Commits](jenkinsci/plugin-pom@plugin-4.73...plugin-4.74)

---
updated-dependencies:
- dependency-name: org.jenkins-ci.plugins:plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [org.jenkins-ci.plugins:jackson2-api](https://github.com/jenkinsci/jackson2-api-plugin) from 2.15.2-350.v0c2f3f8fc595 to 2.15.3-366.vfe8d1fa_f8c87.
- [Release notes](https://github.com/jenkinsci/jackson2-api-plugin/releases)
- [Changelog](https://github.com/jenkinsci/jackson2-api-plugin/blob/master/CHANGELOG.md)
- [Commits](https://github.com/jenkinsci/jackson2-api-plugin/commits)

---
updated-dependencies:
- dependency-name: org.jenkins-ci.plugins:jackson2-api
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [io.jenkins.tools.bom:bom-2.414.x](https://github.com/jenkinsci/bom) from 2423.vce598171d115 to 2516.v113cb_3d00317.
- [Release notes](https://github.com/jenkinsci/bom/releases)
- [Commits](https://github.com/jenkinsci/bom/commits)

---
updated-dependencies:
- dependency-name: io.jenkins.tools.bom:bom-2.414.x
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
…abot/maven/io.jenkins.tools.bom-bom-2.414.x-2516.v113cb_3d00317', 'dependabot/maven/org.jenkins-ci.plugins-aws-credentials-218.v1b_e9466ec5da_', 'dependabot/maven/org.jenkins-ci.plugins-jackson2-api-2.15.3-366.vfe8d1fa_f8c87', 'dependabot/maven/org.jenkins-ci.plugins-plugin-4.74' and 'dependabot/maven/org.testcontainers-testcontainers-1.19.1' into test-aws-sdk-1.12.573
One of the dependencies requires at least 2.414.1
@damentz
Copy link

damentz commented Oct 26, 2023

Can confirm this works, was able to use the C7a8xlarge to complete a package build for Arch Linux. Runtime went from 12 minutes to 7 minutes by switching from C6a8xlarge to C7a8xlarge.

Master Controller: Jenkins v2.429 with JDK 11
Build Node:

INFO: Verifying: java -fullversion
openjdk full version "17.0.8+7-Debian-1deb12u1"
...
<===[JENKINS REMOTING CAPACITY]===>Remoting version: 3181.v78543a_987053

@mytxyang
Copy link

mytxyang commented Nov 8, 2023

Hi, "SDK minimal" and "SDK EC2" binary cannot download now, could you please provider new address?
When can we release this change? We need create Jenkins Dynamic Instance for M7A type soon.

@MarkEWaite
Copy link
Contributor Author

Hi, "SDK minimal" and "SDK EC2" binary cannot download now, could you please provider new address? When can we release this change? We need create Jenkins Dynamic Instance for M7A type soon.

As my time allows, I'll try to provide an updated version of the SDK plugins and the EC2 plugin.

If your organization depends on prompt releases of the EC2 plugin, you should volunteer to help maintain the plugin. That will give you permissions to release new versions and deliver the features that you need and will help the community.

@MarkEWaite
Copy link
Contributor Author

Hi, "SDK minimal" and "SDK EC2" binary cannot download now, could you please provider new address? When can we release this change? We need create Jenkins Dynamic Instance for M7A type soon.

I've updated the links for SDK minimal and SDK EC2 in the pull request description so that they now point to persistent locations.

My earlier comments still apply:

If your organization depends on prompt releases of the EC2 plugin, you should volunteer to help maintain the plugin. That will give you permissions to release new versions and deliver the features that you need and will help the community.

@MarkEWaite MarkEWaite changed the title Test incremental AWS Java SDK 1.12.573-407.x Support new AWS machine types Nov 11, 2023
@MarkEWaite MarkEWaite changed the title Support new AWS machine types [JENKINS-72007] Support new AWS machine types Nov 11, 2023
@MarkEWaite
Copy link
Contributor Author

MarkEWaite commented Nov 11, 2023

@res0nance , @fcojfernandez , @MRamonLeon , @thoulen , or @froblesmartin this has been tested in earlier iterations with good results. Would you be willing to merge and release a new version so that users can access the most recent machine types?

@res0nance res0nance added the enhancement Feature additions or enhancements label Nov 12, 2023
@res0nance res0nance merged commit 1fa8f5f into jenkinsci:master Nov 12, 2023
16 checks passed
@MarkEWaite MarkEWaite deleted the test-aws-sdk-1.12.573 branch November 12, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature additions or enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants