Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.289 LTS update #323

Closed
wants to merge 3 commits into from
Closed

2.289 LTS update #323

wants to merge 3 commits into from

Conversation

offa
Copy link
Contributor

@offa offa commented Oct 21, 2021

v2.289 LTS baseline update. BOM has dropped earlier versions recently (jenkinsci/bom#671) and it fixes the build failure of #298 too.

Some test cases needed to adopt the table-to-div migration.


  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@offa
Copy link
Contributor Author

offa commented Oct 21, 2021

Jenkins still runs the tests on 2.263, even after updating the Jenkinsfile!?

@basil basil mentioned this pull request Oct 21, 2021
@basil
Copy link
Member

basil commented Oct 21, 2021

Jenkins still runs the tests on 2.263, even after updating the Jenkinsfile!?

Because you don't have write access to the repository.

@basil
Copy link
Member

basil commented Oct 21, 2021

Taken care of in #324. Thanks for starting this effort!

@basil basil closed this Oct 21, 2021
@offa
Copy link
Contributor Author

offa commented Oct 22, 2021

Taken care of in #324. Thanks for starting this effort!

Thanks for continuing! 👍

@offa offa deleted the lts_update branch October 22, 2021 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants