Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.277 LTS update #324

Merged
merged 3 commits into from
Oct 21, 2021
Merged

2.277 LTS update #324

merged 3 commits into from
Oct 21, 2021

Conversation

basil
Copy link
Member

@basil basil commented Oct 21, 2021

#323 but based on 2.277 rather than 2.289 and testing against the latest LTS in the Jenkinsfile.

@basil basil added the internal label Oct 21, 2021
@basil basil merged commit 51407fa into jenkinsci:master Oct 21, 2021
@basil basil deleted the lts_update branch October 21, 2021 20:05
@basil basil mentioned this pull request Oct 21, 2021
6 tasks
@batmat
Copy link
Member

batmat commented Nov 12, 2021

@basil thanks! this update incidentally is fixing (also) tables-to-divs compatibility and overall PCT compatibility I'm told, would you mind considering a release? Thanks a lot!

@basil
Copy link
Member Author

basil commented Nov 12, 2021

this update incidentally is fixing (also) tables-to-divs compatibility

I am impressed that tables-to-divs compatibility is fixed in this PR. When I compare the code from before this PR with the code from after this PR, I see no differences that would have fixed tables-to-divs compatibility. I actually see no production code differences at all. This PR only contains changes to Jenkinsfile, pom.xml, and a test.

@batmat
Copy link
Member

batmat commented Nov 12, 2021

Yes. I was unclear: there's a PCT failure related to tables-to-divs. I.e. the change in the src/test/java/hudson/plugins/emailext/ExtendedEmailPublisherDescriptorTest.java class.
So you're right, no production issue actually here afaict.

@basil
Copy link
Member Author

basil commented Nov 16, 2021

Released in 2.85.

@batmat
Copy link
Member

batmat commented Nov 17, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants