Improve messages and localization for Oracle account management Web UI #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-nenashev
approved these changes
Jul 18, 2019
| @@ -0,0 +1,2 @@ | |||
| title=Oracle JDK Credentials saved | |||
There was a problem hiding this comment.
Should it be a full name like in #6 ?
There was a problem hiding this comment.
I have no idea. I'd rather this be merged and let someone adjust it later.
|
retriggering CI |
oleg-nenashev
changed the title
|
Will merge it before the next release, even if #4 (comment) is not addressed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a terrible idea to reuse a string in multiple contexts. I've split the strings as identifiers to make it easier for people to evolve them independently. I've also adjusted the English translations a bit (albeit not independently).