[JENKINS-57394] - Rename the plugin to make the purpose explicit #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-nenashev
commented
Jul 16, 2019
| @@ -14,8 +14,8 @@ | |||
| <jenkins.version>2.112</jenkins.version> | |||
| <java.level>8</java.level> | |||
| </properties> | |||
| <name>JDK Tool Plugin</name> | |||
| <description>Allows the JDK tool to be installed via download from Oracle's website.</description> | |||
| <name>Oracle Java SE Development Kit Installer Plugin</name> | |||
There was a problem hiding this comment.
too long? It will appear in the dependencies list on the plugin website, e.g. https://plugins.jenkins.io/ownership
There was a problem hiding this comment.
🤷♂ Seems fine. Maintainers need to update their core dependency to not pull in unnecessary plugins.
batmat
approved these changes
Jul 16, 2019
dwnusbaum
approved these changes
Jul 16, 2019
varyvol
reviewed
Jul 18, 2019
Co-Authored-By: Evaristo Gutiérrez <egutierrez@cloudbees.com>
|
Will merge it taking the approvals. I will see if I can get #5 in the same release, but maybe having a different one is preferable to avoid going nuclear (new plugin name + red warning in the UC) |
|
Belated 👍 for the recommendation. Thanks for taking it in account Oleg. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jenkins-ci.org/browse/JENKINS-57394
This patch applies some renaming to make the purpose of the plugin explicit.
It also adds some documentation about license constratins to README.
CC @jenkinsci/java11-support