Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-69860] - onclick usage un-inlined for CSP compliance. #47

Closed
wants to merge 3 commits into from
Closed

[JENKINS-69860] - onclick usage un-inlined for CSP compliance. #47

wants to merge 3 commits into from

Conversation

Artmorse
Copy link
Contributor

@Artmorse Artmorse commented Oct 24, 2022

The issue
You can find all the issue details here.

My updates:
I've created a credentialOK.js file to externalized the javascript and I've updated the credentialOK.jelly file.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@Artmorse Artmorse marked this pull request as ready for review October 24, 2022 17:05
@Artmorse
Copy link
Contributor Author

Closed because we don't need the Close button anymore (see the PR#48).

image

@Artmorse
Copy link
Contributor Author

Someone can add the hacktoberfest and hacktoberfest-accepted labels to this PR because it seems that this repository is not participating in Hacktoberfest ? 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant