[JENKINS-69860] - Close button removed. #48
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can find all the issue details here.
This issue was initially the PR#47 but after some discussions, we are arrived to the conclusion to just removed the
Close
button.Why have we decided to remove the
Close
button ?It used the
window.close()
javascript function which don't work anymore (see this StackOverflow thread). So why keep something which does not work from a while ?This view will be displayed just one time (because Jenkins will store the credentials).
The screenshot below show the UI before.
The screenshot bellow show the "new" UI.
Now, we don't have the CSP issue and the button which didn't work has been removed.