Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-69860] - Close button removed. #48

Merged
merged 1 commit into from
Oct 29, 2022
Merged

[JENKINS-69860] - Close button removed. #48

merged 1 commit into from
Oct 29, 2022

Conversation

Artmorse
Copy link
Contributor

You can find all the issue details here.

This issue was initially the PR#47 but after some discussions, we are arrived to the conclusion to just removed the Close button.

Why have we decided to remove the Close button ?
It used the window.close() javascript function which don't work anymore (see this StackOverflow thread). So why keep something which does not work from a while ?
This view will be displayed just one time (because Jenkins will store the credentials).

The screenshot below show the UI before.
image

The screenshot bellow show the "new" UI.
image

Now, we don't have the CSP issue and the button which didn't work has been removed.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@Artmorse
Copy link
Contributor Author

Someone can add the hacktoberfest and hacktoberfest-accepted labels to this PR because it seems that this repository is not participating in Hacktoberfest ? 😊

@jglick jglick added hacktoberfest bug Something isn't working labels Oct 29, 2022
@jglick jglick merged commit 62d2fd4 into jenkinsci:master Oct 29, 2022
@Artmorse Artmorse deleted the JENKINS-69860 branch October 31, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants