Remove assets that have been replaced with SVG versions (#5778)

Co-authored-by: Basil Crow <me@basilcrow.com>

core/src/main/java/hudson/AboutJenkins.java

@@ -18,7 +18,7 @@
 public class AboutJenkins extends ManagementLink {
     @Override
     public String getIconFileName() {
-        return "help.png";
+        return "help.svg";
     }
 
     @Override

core/src/main/java/hudson/diagnosis/OldDataMonitor.java

@@ -454,7 +454,7 @@ public Category getCategory() {
 
         @Override
         public String getIconFileName() {
-            return "document.png";
+            return "document.svg";
         }
 
         @Override

core/src/main/java/hudson/lifecycle/WindowsInstallerLink.java

@@ -80,7 +80,7 @@ private WindowsInstallerLink(File jenkinsWar) {
 
     @Override
     public String getIconFileName() {
-        return "installer.gif";
+        return "installer.svg";
     }
 
     @Override

core/src/main/java/hudson/model/Computer.java

@@ -727,10 +727,10 @@ public void setTemporarilyOffline(boolean temporarilyOffline, OfflineCause cause
     @Exported
     public String getIcon() {
         // The machine was taken offline by someone
-        if (isTemporarilyOffline() && getOfflineCause() instanceof OfflineCause.UserCause) return "computer-user-offline.png";
+        if (isTemporarilyOffline() && getOfflineCause() instanceof OfflineCause.UserCause) return "computer-user-offline.svg";
         // There is a "technical" reason the computer will not accept new builds
-        if (isOffline() || !isAcceptingTasks()) return "computer-x.png";
-        return "computer.png";
+        if (isOffline() || !isAcceptingTasks()) return "computer-x.svg";
+        return "computer.svg";
     }
 
     /**

core/src/main/java/hudson/model/ManagementLink.java

@@ -58,8 +58,7 @@ public abstract class ManagementLink implements ExtensionPoint, Action {
 
     /**
      * Mostly works like {@link Action#getIconFileName()}, except that
-     * the expected icon size is 48x48, not 24x24. So if you give
-     * just a file name, "/images/48x48" will be assumed.
+     * the expected icon format is SVG. So if you give just a file name, "/images/svgs" will be assumed.
      *
      * @return
      *      As a special case, return null to exclude this object from the management link.

core/src/main/java/hudson/security/GlobalSecurityConfiguration.java

@@ -176,7 +176,7 @@ public String getDescription() {
 
     @Override
     public String getIconFileName() {
-        return "secure.png";
+        return "secure.svg";
     }
 
     @Override

core/src/main/java/hudson/security/HudsonPrivateSecurityRealm.java

@@ -846,7 +846,7 @@ public static final class ManageUserLinks extends ManagementLink {
         @Override
         public String getIconFileName() {
             if (Jenkins.get().getSecurityRealm() instanceof HudsonPrivateSecurityRealm)
-                return "user.png";
+                return "user.svg";
             else
                 return null;    // not applicable now
         }

core/src/main/java/jenkins/management/CliLink.java

@@ -39,7 +39,7 @@ public class CliLink extends ManagementLink {
 
     @Override
     public String getIconFileName() {
-        return "terminal.png";
+        return "terminal.svg";
     }
 
     @Override

core/src/main/java/jenkins/management/ConfigureLink.java

@@ -39,7 +39,7 @@ public class ConfigureLink extends ManagementLink {
 
     @Override
     public String getIconFileName() {
-        return "gear2.png";
+        return "gear.svg";
     }
 
     @Override

core/src/main/java/jenkins/management/ConsoleLink.java

@@ -39,7 +39,7 @@ public class ConsoleLink extends ManagementLink {
 
     @Override
     public String getIconFileName() {
-        return "notepad.png";
+        return "notepad.svg";
     }
 
     @Override

core/src/main/java/jenkins/management/NodesLink.java

@@ -39,7 +39,7 @@ public class NodesLink extends ManagementLink {
 
     @Override
     public String getIconFileName() {
-        return "network.png";
+        return "network.svg";
     }
 
     @Override

core/src/main/java/jenkins/management/PluginsLink.java

@@ -42,7 +42,7 @@ public class PluginsLink extends ManagementLink {
 
     @Override
     public String getIconFileName() {
-        return "plugin.png";
+        return "plugin.svg";
     }
 
     @Override

core/src/main/java/jenkins/management/ReloadLink.java

@@ -39,7 +39,7 @@ public class ReloadLink extends ManagementLink {
 
     @Override
     public String getIconFileName() {
-        return "refresh.png";
+        return "refresh.svg";
     }
 
     @Override

core/src/main/java/jenkins/management/ShutdownLink.java

@@ -47,7 +47,7 @@ public class ShutdownLink extends ManagementLink {
 
     @Override
     public String getIconFileName() {
-        return "system-log-out.png";
+        return "system-log-out.svg";
     }
 
     @Override

core/src/main/java/jenkins/management/StatisticsLink.java

@@ -39,7 +39,7 @@ public class StatisticsLink extends ManagementLink {
 
     @Override
     public String getIconFileName() {
-        return "monitor.png";
+        return "monitor.svg";
     }
 
     @Override

core/src/main/java/jenkins/management/SystemInfoLink.java

@@ -39,7 +39,7 @@ public class SystemInfoLink extends ManagementLink {
 
     @Override
     public String getIconFileName() {
-        return "computer.png";
+        return "computer.svg";
     }
 
     @Override

core/src/main/java/jenkins/management/SystemLogLink.java

@@ -39,7 +39,7 @@ public class SystemLogLink extends ManagementLink {
 
     @Override
     public String getIconFileName() {
-        return "clipboard.png";
+        return "clipboard.svg";
     }
 
     @Override

core/src/main/java/jenkins/model/ModelObjectWithContextMenu.java

@@ -164,7 +164,7 @@ public ContextMenu add(Node n) {
             Computer c = n.toComputer();
             return add(new MenuItem()
                 .withDisplayName(n.getDisplayName())
-                .withIconClass(c == null ? "icon-computer" : c.getIconClassName())
+                .withStockIcon(c == null ? "computer.svg" : c.getIcon())
                 .withContextRelativeUrl(n.getSearchUrl()));
         }
 

core/src/main/java/jenkins/tools/GlobalToolConfiguration.java

@@ -51,7 +51,7 @@ public class GlobalToolConfiguration extends ManagementLink {
 
     @Override
     public String getIconFileName() {
-        return "setting.png";
+        return "setting.svg";
     }
 
     @Override

core/src/main/resources/hudson/model/DirectoryBrowserSupport/dir.jelly

@@ -47,7 +47,7 @@ THE SOFTWARE.
             ${%No files in directory}
            <j:if test="${showSymlinkWarning}">
              <p>
-                <img id="symlinkalert" src="${imagesURL}/16x16/warning.png"/>
+                <img id="symlinkalert" src="${imagesURL}/svgs/warning.svg" width="16" height="16" />
                ${%Symlinks are hidden}
              </p>
             </j:if>
@@ -114,7 +114,7 @@ THE SOFTWARE.
            </table>
            <j:if test="${showSymlinkWarning}">
              <p>
-                <img id="alert" src="${imagesURL}/16x16/warning.png"/>
+                <img id="alert" src="${imagesURL}/svgs/warning.svg" width="16" height="16" />
                ${%Symlinks are hidden}
              </p>
             </j:if>

core/src/main/resources/hudson/slaves/SlaveComputer/systemInfo.jelly

@@ -35,7 +35,7 @@ THE SOFTWARE.
     <l:main-panel>
 
       <h1>
-        <img src="${imagesURL}/48x48/${it.icon}" width="48" height="48" alt=""/>
+        <img src="${imagesURL}/svgs/${it.icon}" width="48" height="48" alt=""/>
         ${it.caption} ${%System Information}
         <j:if test="${!empty(it.node.nodeDescription)}">
           <span style="font-size:smaller">(${it.node.nodeDescription})</span>

core/src/main/resources/jenkins/model/Jenkins/manage.jelly

@@ -66,7 +66,7 @@ THE SOFTWARE.
 
             <j:if test="${icon!=null}">
               <div class="jenkins-section__item">
-              <j:set var="iconUrl" value="${icon.startsWith('/') ? resURL+icon : imagesURL + '/48x48/' + icon}" />
+              <j:set var="iconUrl" value="${icon.startsWith('/') ? resURL+icon : imagesURL + '/svgs/' + icon}" />
               <j:set var="alt" value="${icon.replaceAll('\\d*\\.[^.]+$', '')}"/>
               ${taskTags!=null and attrs.contextMenu!='false' ? taskTags.add(m.urlName, iconUrl, m.displayName, m.requiresPOST, m.requiresConfirmation) : null}
               <j:choose>

core/src/main/resources/lib/hudson/executors.jelly

@@ -39,7 +39,7 @@ THE SOFTWARE.
         <st:nbsp/>
         <j:choose>
           <j:when test="${c.offlineCause!=null and !c.connecting}">
-            (<l:icon class="icon-error icon-sm" title="${c.offlineCause}"/> ${%offline})
+            (<img src="${imagesURL}/svgs/error.svg" width="16" height="16" title="${c.offlineCause}"/> ${%offline})
           </j:when>
           <j:when test="${c.connecting}">
             (<l:icon class="icon-hourglass icon-sm"/>${%launching})

core/src/main/resources/lib/hudson/scriptConsole.jelly

@@ -33,13 +33,13 @@ THE SOFTWARE.
     <l:main-panel>
       <j:choose>
         <j:when test="${it.icon == null}">
-          <j:set var="icon" value="notepad.png"/>
+          <j:set var="icon" value="notepad.svg"/>
         </j:when>
         <j:otherwise>
           <j:set var="icon" value="${it.icon}"/>
         </j:otherwise>
       </j:choose>
-      <h1><img src="${imagesURL}/48x48/${icon}" width="48" height="48" alt=""/> ${%Script Console}</h1>
+      <h1><img src="${imagesURL}/svgs/${icon}" width="48" height="48" alt=""/> ${%Script Console}</h1>
 
       <j:choose>
         <j:when test="${it.channel != null}">

test/src/test/java/hudson/model/ViewTest.java

@@ -237,7 +237,7 @@ public class ViewTest {
         // boolean folderPluginClassesLoaded = (j.jenkins.getDescriptor("com.cloudbees.hudson.plugins.folder.Folder") != null);
         if (!folderPluginActive && folderPluginClassesLoaded) {
             // reset the icon added by Folder because the plugin resources are not reachable
-            IconSet.icons.addIcon(new Icon("icon-folder icon-md", "24x24/folder.gif", "width: 24px; height: 24px;"));
+            IconSet.icons.addIcon(new Icon("icon-folder icon-md", "svgs/folder.svg", "width: 24px; height: 24px;"));
         }
 
         WebClient webClient = j.createWebClient()