Remove assets that have been replaced with SVG versions

[janfaracik]

Split from #5777 to keep the first PR independently mergeable as this PR is rather large..

Proposed changelog entries

• Remove images from core that have been replaced by SVG images.

Proposed upgrade guidelines

Jenkins has removed a large number of static assets. Ensure all your plugins are the most recent release before updating core, otherwise image may be missing. Check for new plugin versions immediately after the core update and install available updates.

Maintainer checklist

Before the changes are marked as ready-for-merge:

• There are at least 2 approvals for the pull request and no outstanding requests for change
• Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
• Changelog entries in the PR title and/or Proposed changelog entries are correct
• Proper changelog labels are set so that the changelog can be generated automatically
• If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
• If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[timja]

Pretty much all the symbols in the context menu are broken:

(only issue I could find)

[timja]

conflicted

[NotMyFault]

The icon at the script console is broken as well.

[timja]

ATH tests passed: jenkinsci/acceptance-test-harness#714

Bom tests fail: https://github.com/jenkinsci/bom/pull/729/checks?check_run_id=4291442648

https://github.com/jenkinsci/scm-api-plugin/blob/master/src/test/java/jenkins/scm/impl/avatars/AvatarCacheTest.java#L119

[timja]

It fails because the test is using search.png from core:
https://github.com/jenkinsci/scm-api-plugin/blob/master/src/test/java/jenkins/scm/impl/avatars/AvatarCacheTest.java#L129

The avatar cache only supports png so either need to switch to one not being removed or move an image to the plugin (probably better)

[timja]

Sorted in jenkinsci/scm-api-plugin#102 by copying resource to plugin.

[janfaracik]

Sorted in jenkinsci/scm-api-plugin#102 by copying resource to plugin.

That's amazing, thanks a bunch Tim :)

[NotMyFault]

Are certain symbols kept for legacy purposes, for example, go-next is superseded by next, document_edit by notepad, text by document or text-error by delete-document, or does the removal only apply to icons that share the same name, not the same graphic?

[timja]

Removing on-hold. Pretty much everything is released now and it's past the cut-off for the next LTS baseline.

ping @jenkinsci/core-pr-reviewers

[NotMyFault]

LGTM, my and the other outstanding concerns have been addressed.

The majority of PRs I submitted have been merged and released by now, other ones can be delivered at a later point I guess. Good call to unblock it 👍🏻

[timja]

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

[daniel-beck]

Given that this requires updates of tons of plugins, I'm surprised there are no upgrade notes.

[timja]

Given that this requires updates of tons of plugins, I'm surprised there are no upgrade notes.

I added a somewhat generic update your plugins, not sure how these are phrased normally.

[NotMyFault]

Given that this requires updates of tons of plugins, I'm surprised there are no upgrade notes.

I added a somewhat generic update your plugins, not sure how these are phrased normally.

If an upgrade guide (for developers) is needed, it would make sense to outline the impact a little more, I guess?
Could include that static file access via the image path is no longer possible for GIFs and PNGs, that are superseded by SVGs, and it's recommended to access icons via the icon class. That way Jenkins automatically picks a GIF, PNG or SVG, based on the version you're using 🤔
At least, that was my go-to approach for the PRs.

[timja]

The 'upgrade guide' is for administrators not developers, although a developer guide can be added to https://www.jenkins.io/doc/developer/views/

like the https://www.jenkins.io/doc/developer/views/table-to-div-migration/ if there's any volunteers

[Bananeweizen]

The removal of "star-gold.png" and "star.png" broke the favorites plugin. See https://github.com/jenkinsci/favorite-plugin/blob/master/src/main/resources/hudson/plugins/favorite/assets.css#L10.

[daniel-beck]

@Bananeweizen Please report bugs in the appropriate issue tracker.

[Bananeweizen]

@daniel-beck Done. Would it be reasonable to set the PR author as assignee or leave it unassigned to have the whole community grab it?
https://issues.jenkins.io/browse/JENKINS-67737

[boczh]

JENKINS-67176 not only favorite plugin affected when I updated from 2.332 to 2.333... Icons disappeared for the following plugins as well: https://plugins.jenkins.io/job-import-plugin/ and Modules icon disappeared from Maven Project. Solved by reverting back to 2.332

[NotMyFault]

JENKINS-67176 not only favorite plugin affected when I updated from 2.332 to 2.333... Icons disappeared for the following plugins as well: https://plugins.jenkins.io/job-import-plugin/ and Modules icon disappeared from Maven Project. Solved by reverting back to 2.332

Please raise an issue on Jira or GitHub, depending what issue tracker the plugin uses.
For the favorite plugin, I have a fix wip.

[MarkEWaite]

Issue already reported for favorite plugin.

See the "Report an issue" link on the job import plugins page for a guided start to report an issue with the job import plugin.

[basil]

Causes JENKINS-68022.

[ikedam]

Notes for plugins migrating ${imageURL} to <layout:icon>:

• <layout:icon> doesn't accept extra class. Adding a developer-defined class to the class attributes results broken icon: https://issues.jenkins.io/browse/JENKINS-68286
• Icon sizes will be specified with css width and height in <layout:icon>. This means adding padding or border results smaller-sized icon.
  • Anyway applying padding to icons is strange manner and margin is better.
  • Also see: https://developer.mozilla.org/en-US/docs/Web/CSS/box-sizing

[daniel-beck]

Caused JENKINS-72673.