Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Jenkins to override icons on newer versions #481

Merged

Conversation

NotMyFault
Copy link
Member

@NotMyFault NotMyFault commented Nov 17, 2021

Replace icon paths to allow core to override icons on modern versions to display SVGs over PNGs, if available, in favor of core getting a rid of PNG icons in a foreseeable future: jenkinsci/jenkins#5778
Also exchange the pause icon in the same run.

Before:

After:

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@timja timja requested a review from a team November 30, 2021 08:04
@jglick
Copy link
Member

jglick commented Nov 30, 2021

@car-roll car-roll merged commit 00e79c8 into jenkinsci:master Nov 30, 2021
@NotMyFault NotMyFault deleted the style/master/allow-overriding-icons branch November 30, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants