Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-52019] - Update Groovy from 2.4.11 to 2.4.12 to pick up fixes towards Java 11 support #3643

Merged
merged 1 commit into from
Sep 22, 2018

Conversation

oleg-nenashev
Copy link
Member

See JENKINS-52019, it is a core counterpart for jenkinsci/workflow-support-plugin#68. Requires sign-off from @svanoort before going forward

Testing:

  • Spot-check during the Java 10+ hackathon (on Java 8, 10, 11)
  • Soak testing on @oleg-nenashev's environment (~2 weeks, Java 8)
  • Testing for memory leaks by @svanoort . Originally we suspected a memory leak, but according to tests there is no evidence of that which would block the change upstreaming

foo

Proposed changelog entries

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@jenkinsci/sig-platform @svanoort

@oleg-nenashev oleg-nenashev added the java11 Java 11 support in Jenkins label Sep 22, 2018
Copy link
Member

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Member

@svanoort svanoort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving, but we should watch feedback on the weekly carefully just in case (we cannot readily cover every possible Groovy failure mode

@oleg-nenashev
Copy link
Member Author

we should watch feedback on the weekly carefully just in case (we cannot readily cover every possible Groovy failure mode

for sure

@oleg-nenashev
Copy link
Member Author

Merging. It has been soak tested for long, and it makes sense to proceed so we have more time for evaluation before LTS

@oleg-nenashev oleg-nenashev merged commit 2f0aafa into jenkinsci:master Sep 22, 2018
jglick added a commit to jglick/pipeline-model-definition-plugin that referenced this pull request Jun 11, 2019
bitwiseman pushed a commit to bitwiseman/pipeline-model-definition-plugin that referenced this pull request Jun 12, 2019
bitwiseman pushed a commit to bitwiseman/pipeline-model-definition-plugin that referenced this pull request Jun 12, 2019
bitwiseman pushed a commit to bitwiseman/pipeline-model-definition-plugin that referenced this pull request Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java11 Java 11 support in Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants