Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java11 support - clean version #68

Merged
merged 19 commits into from
Jan 3, 2019

Conversation

svanoort
Copy link
Member

@svanoort svanoort commented Jun 22, 2018

Clean version of #67 which pulls in the released versions.

TODO:

  • Verify this is safe to run with Java 8 (no issues from the JBoss Marshalling bump)
  • Test upgrading to this version with Pipelines running from old version
  • Add Enforcer exclusion for this JBoss Marshalling to allow use of multi-release JAR there.

@svanoort
Copy link
Member Author

Still able to run Pipelines and start Jenkins with Java 8 on core 2.89.x -- as long as we revert the core dependency bump so it does not require 1.129 releases.

This means the JBoss marshalling dependency is clean - barring enforcer grumbling about the multi-release JAR usage.

@oleg-nenashev oleg-nenashev self-requested a review June 30, 2018 20:25
@oleg-nenashev
Copy link
Member

@jenkinsci/java10-support

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O'd guess it requires jenkinsci/plugin-pom#113 to be finalized so that tests are reenabled

pom.xml Outdated
@@ -28,7 +28,7 @@
<parent>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>plugin</artifactId>
<version>3.12</version>
<version>3.16</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now you can update to 3.17 with newer Animal Sniffer

Jenkinsfile Outdated
@@ -1 +1,2 @@
buildPlugin()
//TODO: Currently some tests fail (JENKINS-52014, etc.)
buildPlugin(tests: [skip: true])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps better to @Ignore those so reviewers can see exactly what is still broken.

<rules>
<enforceBytecodeVersion>
<excludes combine.children="append">
<!-- Prevents enforcer complaining about multi-release JAR -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where it the upstream bug?

@svanoort
Copy link
Member Author

@oleg-nenashev Note: the JBoss marshalling change is not back-compatible in the binary format -- that merits a serious upgrade warning (CompatibleSince, etc).

Does not appear to have a memory leak, after tens of thousands of builds.

Build code, with build rotation set to keep last 100 builds.


class Animal {
    String code;
    
    public Animal(String entry) {
        this.code = entry;
    }
}

for(int i=0; i<5; i++) {
    Animal an = new Animal("named"+i);
}

for (int i=0;i<5; i++) {
    echo 'cheese'
}

screen shot 2018-09-21 at 6 39 59 pm

@oleg-nenashev oleg-nenashev changed the title Java10 support - clean version Java11 support - clean version Oct 1, 2018
@oleg-nenashev
Copy link
Member

Deployed the current version as 2.23-20181122.094059-1

@oleg-nenashev
Copy link
Member

CC @jenkinsci/java11-support

@batmat
Copy link
Member

batmat commented Nov 22, 2018

I confirm using the SNAPSHOT deployed by @oleg-nenashev I'm able to remove the immediate JBoss Marshalling related Pipeline crash. I tested only on a Hello World on a fresh instance though. Testing a bit more deeply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants