-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java11 support - clean version #68
Conversation
… get Java 9+ fixes
[JENKINS-52001] - Update JBoss Marshalling to 2.0.5.Final in order to get Java 9+ fixes
[JENKINS-52001] - Enable Incrementals deployment for the Java 10 support branch
Still able to run Pipelines and start Jenkins with Java 8 on core 2.89.x -- as long as we revert the core dependency bump so it does not require 1.129 releases. This means the JBoss marshalling dependency is clean - barring enforcer grumbling about the multi-release JAR usage. |
@jenkinsci/java10-support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
O'd guess it requires jenkinsci/plugin-pom#113 to be finalized so that tests are reenabled
pom.xml
Outdated
@@ -28,7 +28,7 @@ | |||
<parent> | |||
<groupId>org.jenkins-ci.plugins</groupId> | |||
<artifactId>plugin</artifactId> | |||
<version>3.12</version> | |||
<version>3.16</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now you can update to 3.17 with newer Animal Sniffer
Jenkinsfile
Outdated
@@ -1 +1,2 @@ | |||
buildPlugin() | |||
//TODO: Currently some tests fail (JENKINS-52014, etc.) | |||
buildPlugin(tests: [skip: true]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps better to @Ignore
those so reviewers can see exactly what is still broken.
<rules> | ||
<enforceBytecodeVersion> | ||
<excludes combine.children="append"> | ||
<!-- Prevents enforcer complaining about multi-release JAR --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where it the upstream bug?
…upport-clean # Conflicts: # pom.xml
@oleg-nenashev Note: the JBoss marshalling change is not back-compatible in the binary format -- that merits a serious upgrade warning (CompatibleSince, etc). Does not appear to have a memory leak, after tens of thousands of builds. Build code, with build rotation set to keep last 100 builds.
|
…upport-clean # Conflicts: # pom.xml
Deployed the current version as |
CC @jenkinsci/java11-support |
I confirm using the SNAPSHOT deployed by @oleg-nenashev I'm able to remove the immediate JBoss Marshalling related Pipeline crash. I tested only on a Hello World on a fresh instance though. Testing a bit more deeply. |
Clean version of #67 which pulls in the released versions.
TODO: