[JENKINS-54484] - Java 10 Support + clean + verify compatibility with old Program.Dat #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… get Java 9+ fixes
[JENKINS-52001] - Update JBoss Marshalling to 2.0.5.Final in order to get Java 9+ fixes
[JENKINS-52001] - Enable Incrementals deployment for the Java 10 support branch
…upport-clean # Conflicts: # pom.xml
| /** | ||
| * Tests deserializing program.dat, useful to catch | ||
| */ | ||
| public class DeserializeUpdate { |
There was a problem hiding this comment.
Makes sense to upstream the test to the master branch. It is helpful independently of whether we merge it or not
There was a problem hiding this comment.
We don't generally upstream failing tests
There was a problem hiding this comment.
But it should be passing on Java 8, no?
There was a problem hiding this comment.
@oleg-nenashev No, because the actual code binary format is different, on Java 8 as well -- it's the bump to the marshaller that does it, not the specific java version in use.
|
Created https://issues.jenkins-ci.org/browse/JENKINS-54484 to track the problem separately |
oleg-nenashev
changed the title
jglick
reviewed
Nov 26, 2018
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jenkins-ci</groupId> | ||
| <artifactId>annotation-indexer</artifactId> |
There was a problem hiding this comment.
Should not be here. Defined in the parent POM.
|
Superseded by #84. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #68 with explicit code coverage (
@LocalDatatest) to test compatibility ofprogram.datwritten with current JBoss Marshalling (1.4.12-jenkins-3). From JW|DW Nice Community Hackfest.Investigation showed that:
Diff link for Jboss Marshalling between those versions.
Unknown
Error reading the old Program.dat, from Marshalling 2.0.5.Final
Root cause: gets a byte 0 for the first byte of the object, but isn't expecting 0.
History for unmarshaller: Github Jboss marshalling link to history.
Possible workaround suggestion from @olivergondza that we might shade the old JBoss marshalling version and fall back to it if the new marshaller fails -- if compat is important. Alternative workaround solution is to include a big compatibility warning in the changelog for the upgrade, and tell users to finish their Pipelines before upgrading.
Issue #2: Persistence After Shutdown Of Jenkins
This occurs with the above error - it seems likely to be caused by the error handling if we fail to load the Pipeline program, and manifests with the latest workflow-job and workflow-cps versions (2.25 and 2.59, respectively). The cause is that we're still trying to write Pipeline data even after Jenkins shutdown (
Jenkins.getInstance()is null). It is likely an independent persistence model problem in workflow-cps -- and if resolved satisfactorily (or proven) to be so, we can probably release the JBoss bump with the workarounds above.