[JENKINS-54484] - Java 10 Support + clean + verify compatibility with old Program.Dat #77
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| package org.jenkinsci.plugins.workflow.support.pickles.serialization; | ||
|
|
||
| import jenkins.model.Jenkins; | ||
| import org.jenkinsci.plugins.workflow.job.WorkflowJob; | ||
| import org.jenkinsci.plugins.workflow.job.WorkflowRun; | ||
| import org.jenkinsci.plugins.workflow.support.steps.input.InputAction; | ||
| import org.jenkinsci.plugins.workflow.support.steps.input.InputStepExecution; | ||
| import org.junit.Assert; | ||
| import org.junit.ClassRule; | ||
| import org.junit.Ignore; | ||
| import org.junit.Rule; | ||
| import org.junit.Test; | ||
| import org.jvnet.hudson.test.BuildWatcher; | ||
| import org.jvnet.hudson.test.JenkinsRule; | ||
| import org.jvnet.hudson.test.recipes.LocalData; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| /** | ||
| * Tests deserializing program.dat, useful to catch | ||
| */ | ||
| public class DeserializeUpdate { | ||
|
There was a problem hiding this comment. Makes sense to upstream the test to the master branch. It is helpful independently of whether we merge it or not There was a problem hiding this comment. We don't generally upstream failing tests There was a problem hiding this comment. But it should be passing on Java 8, no? There was a problem hiding this comment. @oleg-nenashev No, because the actual code binary format is different, on Java 8 as well -- it's the bump to the marshaller that does it, not the specific java version in use. |
||
| @ClassRule | ||
| public static BuildWatcher buildWatcher = new BuildWatcher(); | ||
| @Rule | ||
| public JenkinsRule r = new JenkinsRule(); | ||
|
|
||
| private static InputStepExecution getInputStepExecution(WorkflowRun run, String inputMessage) throws Exception { | ||
| InputAction ia = run.getAction(InputAction.class); | ||
| List<InputStepExecution> execList = ia.getExecutions(); | ||
| return execList.stream().filter(e -> inputMessage.equals(e.getInput().getMessage())).findFirst().orElse(null); | ||
| } | ||
|
|
||
| @Test | ||
| @LocalData | ||
| @Ignore | ||
| public void testBasicSerializeDeserialize() throws Exception { | ||
| WorkflowJob job = Jenkins.getInstance().getItemByFullName("serial-format", WorkflowJob.class); | ||
| WorkflowRun run = job.getLastBuild(); | ||
| Assert.assertTrue(run.isBuilding()); | ||
| InputStepExecution ise = getInputStepExecution(run, "give me cheese"); | ||
| ise.doProceedEmpty(); | ||
| r.waitForCompletion(run); | ||
| r.assertBuildStatusSuccess(run); | ||
| } | ||
| } | ||
Binary file not shown.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not be here. Defined in the parent POM.