Skip to content

Commit

Permalink
Merge pull request #143 from basil/javamail-upgrade
Browse files Browse the repository at this point in the history
Use detached JavaMail plugin
  • Loading branch information
jglick authored Jul 19, 2022
2 parents 2869a23 + 4cee55b commit c8b085a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 11 deletions.
11 changes: 3 additions & 8 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
</licenses>
<properties>
<changelist>999999-SNAPSHOT</changelist>
<jenkins.version>2.289.1</jenkins.version>
<jenkins.version>2.332.1</jenkins.version>
<gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo>
<useBeta>true</useBeta>
</properties>
Expand All @@ -31,8 +31,8 @@
<dependencies>
<dependency>
<groupId>io.jenkins.tools.bom</groupId>
<artifactId>bom-2.289.x</artifactId>
<version>1075.v14bef33e5d7b</version>
<artifactId>bom-2.332.x</artifactId>
<version>1155.v77b_fd92a_26fc</version>
<scope>import</scope>
<type>pom</type>
</dependency>
Expand All @@ -53,10 +53,6 @@
<groupId>org.hamcrest</groupId>
<artifactId>hamcrest-core</artifactId>
</exclusion>
<exclusion> <!-- TODO pending https://github.com/jenkinsci/plugin-util-api-plugin/releases/tag/v2.9.0 in bom -->
<groupId>javax.annotation</groupId>
<artifactId>javax.annotation-api</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
Expand All @@ -79,7 +75,6 @@
<dependency>
<groupId>io.jenkins.plugins</groupId>
<artifactId>javax-mail-api</artifactId>
<version>1.6.2-2</version>
</dependency>
<dependency>
<groupId>org.mockito</groupId>
Expand Down
6 changes: 3 additions & 3 deletions src/test/java/hudson/tasks/MailerTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@
import jenkins.model.JenkinsLocationConfiguration;

import java.io.IOException;
import java.io.UncheckedIOException;
import java.util.Collection;
import java.util.Optional;
import java.util.concurrent.atomic.AtomicLong;
Expand Down Expand Up @@ -300,9 +301,8 @@ public CleanJenkinsLocationConfiguration() {
public synchronized void load() {
try {
getConfigFile().delete();
} catch (Exception e) {
// TODO 2.325+ catch IOException and throw UncheckedIOException
throw new RuntimeException(e);
} catch (IOException e) {
throw new UncheckedIOException(e);
}
super.load();
}
Expand Down

0 comments on commit c8b085a

Please sign in to comment.