Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use detached JavaMail plugin #143

Merged
merged 8 commits into from
Jul 19, 2022
Merged

Conversation

basil
Copy link
Member

@basil basil commented Jan 8, 2022

Downstream of #142 and jenkinsci/jenkins#6165. Bumps the baseline to one containing jenkinsci/jenkins#6165, thus using the detached JavaMail plugin, but does not upgrade to Jakarta Mail.

@basil basil marked this pull request as draft January 8, 2022 15:54
@basil basil closed this Jan 21, 2022
@basil basil reopened this Jan 21, 2022
@basil basil marked this pull request as ready for review January 21, 2022 18:29
@basil
Copy link
Member Author

basil commented Jan 21, 2022

I've marked this as ready for review because the PR is complete, but I'm not in any rush for this to be merged due to the bump in Jenkins baseline. I just wanted to file the PR to close the loop on remaining tasks regarding detaching JavaMail.

@alecharp alecharp added dependencies Pull requests that update a dependency file chore labels Apr 27, 2022
@basil
Copy link
Member Author

basil commented Apr 27, 2022

My preference would be to release #168 before releasing this so that the fix from #168 is available to older BOM lines.

@basil
Copy link
Member Author

basil commented Apr 27, 2022

@alecharp Build is green on this as well, though as noted my preference is to release #168 first.

@alecharp
Copy link
Member

I agree, those changes seems a bit more "dangerous". I'll release the plugin now with this for now.

@basil
Copy link
Member Author

basil commented Apr 27, 2022

#157 and #143 are both safe, but #143 (this PR) contains a mildly aggressive core baseline bump that would prevent it from being usable in older BOM lines (e.g. 2.289.x).

@jglick
Copy link
Member

jglick commented Jul 19, 2022

@alecharp if you do not mind, I would like to release this and #144 and move on to an even newer core bump to deal with instance-identity.

@jglick jglick removed the chore label Jul 19, 2022
@jglick jglick merged commit c8b085a into jenkinsci:master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants