Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-41631] Demonstration of POM update #113

Merged

Conversation

jglick
Copy link
Member

@jglick jglick commented Jun 13, 2017

Downstream of jenkinsci/plugin-pom#67.

@reviewbybees

@ghost
Copy link

ghost commented Jun 13, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@jglick
Copy link
Member Author

jglick commented Jun 13, 2017

Was building with JDK 7.

@jglick jglick closed this Jun 13, 2017
@jglick jglick reopened this Jun 13, 2017
pom.xml Outdated
@@ -4,7 +4,8 @@
<parent>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>plugin</artifactId>
<version>2.23</version>
<version>2.31-20170612.235547-1</version> <!-- TODO https://github.com/jenkinsci/plugin-pom/pull/67 -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't need this right away, do you want to wait until the next version is cut? This plugin isn't released frequently, so it might be worth waiting until the plugin-pom is updated.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly I was not proposing a merge unless and until the dependency is merged and released. That just applies to any use of snapshots.

Really this PR is not intended to accomplish anything in particular except to demonstrate that the upstream PR is consumable.

@oleg-nenashev
Copy link
Member

oleg-nenashev commented Jun 19, 2017

Target release date - July 10

@jglick
Copy link
Member Author

jglick commented Jun 19, 2017

@reviewbybees done

@jglick jglick removed the on-hold label Jun 26, 2017
@oleg-nenashev oleg-nenashev merged commit 95056c1 into jenkinsci:master Sep 1, 2017
@jglick jglick deleted the requireUpperBoundDeps-JENKINS-41631 branch October 4, 2017 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants