Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-41631] Running requireUpperBoundDeps #67

Merged
merged 5 commits into from
Jun 26, 2017
Merged

[JENKINS-41631] Running requireUpperBoundDeps #67

merged 5 commits into from
Jun 26, 2017

Conversation

jglick
Copy link
Member

@jglick jglick commented Jun 12, 2017

This was referenced Jun 12, 2017
Merged
Merged
Merged
@ghost
Copy link

ghost commented Jun 13, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@jglick
Copy link
Member Author

jglick commented Jun 13, 2017

jenkinsci/workflow-cps-global-lib-plugin#38 failed against 2.47 due to:

Require upper bound dependencies error for org.kohsuke:access-modifier-annotation:1.4 paths to dependency are:
+-org.jenkins-ci.plugins.workflow:workflow-cps-global-lib:2.9-SNAPSHOT
  +-org.jenkins-ci.main:jenkins-core:2.47
    +-org.kohsuke:access-modifier-annotation:1.4
and
+-org.jenkins-ci.plugins.workflow:workflow-cps-global-lib:2.9-SNAPSHOT
  +-org.jenkins-ci.main:jenkins-core:2.47
    +-org.jenkins-ci.main:cli:2.47
      +-org.kohsuke:access-modifier-annotation:1.7

This is fixed by jenkinsci/jenkins#2866 in 2.61 but perhaps org.kohsuke:access-modifier-annotation needs to be excluded so as to permit building against intermediate versions, especially 2.60.x which will not get this backport.

@jglick
Copy link
Member Author

jglick commented Jun 13, 2017

Inconsistency introduced by jenkinsci/jenkins#2656 in 2.36.

@jglick
Copy link
Member Author

jglick commented Jun 19, 2017 •
edited
Loading

@reviewbybees done

On hold pending MENFORCER-273 release.

@jglick
Copy link
Member Author

jglick commented Jun 19, 2017

call for release by @stephenc today

@jglick
Copy link
Member Author

jglick commented Jun 20, 2017

1.4.2 released but not yet on Central.

@jglick
Copy link
Member Author

jglick commented Jun 23, 2017

Seems @stephenc had been planning to release this but ran into some technical issues. I may just push a temporary 1.4.1.jenkins-1 to our internal repo to unblock the POM release if there are no objections.

@stephenc
Copy link
Member

@jglick go with pushing to the jenkins repo with -jenkins-1

@jglick
Using private build of 1.4.2.jenkins-1 to pick up MENFORCER-273 which…
74f4f58 
… was merged but not yet released.

git checkout bd11bcad2ea7d5ff2713be4dbcc2cbbf745a552c # enforcer-1.4.2 prepared but not tagged?
mvn versions:set -DnewVersion=1.4.2.jenkins-1
mvn -Papache-release,run-its clean deploy -DaltDeploymentRepository=maven.jenkins-ci.org::default::https://repo.jenkins-ci.org/releases/
@jglick jglick merged commit 17cc56d into jenkinsci:master Jun 26, 2017
@jglick jglick deleted the requireUpperBoundDeps-JENKINS-41631 branch June 26, 2017 21:15
@oleg-nenashev oleg-nenashev mentioned this pull request Jul 4, 2017
Closed
@oleg-nenashev
Copy link
Member

I have also created apache/maven-enforcer#25 to address the case with test dependencies

jglick
jglick commented Jul 31, 2017
View reviewed changes
pom.xml
@@ -321,7 +321,7 @@
</plugin>
<plugin>
<artifactId>maven-enforcer-plugin</artifactId>
<version>1.4.1</version>
<version>1.4.2.jenkins-1</version> <!-- TODO update to official 1.4.2 or 3.0.0 when available -->
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.0.0-M1 is also available.

This was referenced Jul 31, 2017
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abayer abayer abayer approved these changes

@stephenc stephenc stephenc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jglick @stephenc @oleg-nenashev @abayer