Get annotation versions from core BOM #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
commented
Dec 16, 2021
| <scope>provided</scope> | ||
| <optional>true</optional> |
There was a problem hiding this comment.
I'm not quite sure why the other annotation dependencies have both <scope>provided</scope> and <optional>true</optional>, but I figured I might as well make this one consistent with them.
jglick
approved these changes
Dec 16, 2021
timja
approved these changes
Dec 16, 2021
10 tasks
|
Let me know if you need a release. Cannot recall if you have permissions to do so yourself. |
Thanks. I will probably try to get a few more changes in before I cut a release. I filed jenkins-infra/repository-permissions-updater#2264 to sort out permissions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements choice 2 from this mailing list thread.