Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get annotation versions from core BOM #470

Merged
merged 2 commits into from
Dec 17, 2021
Merged

Get annotation versions from core BOM #470

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d8833c
Get annotation versions from core BOM
basil Dec 16, 2021
d0ed92c
Exclude org.kohsuke:access-modifier-annotation
basil Dec 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,6 @@
<dependency>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-annotations</artifactId>
<version>4.5.1</version>
<scope>provided</scope>
<optional>true</optional>
<exclusions>
Expand Down Expand Up @@ -250,8 +249,8 @@
<dependency>
<groupId>org.kohsuke</groupId>
<artifactId>access-modifier-annotation</artifactId>
<version>${access-modifier-checker.version}</version>
<scope>provided</scope>
<optional>true</optional>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not quite sure why the other annotation dependencies have both <scope>provided</scope> and <optional>true</optional>, but I figured I might as well make this one consistent with them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just belt and braces.

<exclusions>
<exclusion>
<!-- provided by Jenkins core -->
Expand Down Expand Up @@ -563,6 +562,7 @@
<exclude>com.google.code.findbugs:annotations</exclude>
<exclude>com.google.code.findbugs:jsr305</exclude> <!-- ditto -->
<exclude>net.java.dev.jna:jna</exclude> <!-- needed for Jenkins 1.585 and earlier -->
<exclude>org.kohsuke:access-modifier-annotation</exclude>
</excludes>
</requireUpperBoundDeps>
</rules>
Expand Down